Skip to content
Snippets Groups Projects
  1. Oct 07, 2023
    • Valtteri Koskivuori's avatar
      Fix bug that causes jumpy keyboard backlight adjustment · 11896702
      Valtteri Koskivuori authored
      Here, I actually adjust the hardware parameters, these settings work the
      best based on my understanding of Atmel docs, and experimentation.
      
      The key change is to set the clock select parameters to choose a
      prescale that divides the IO clock by 8.
      In the original implementation, a comment implied that the intent was to
      set the prescale to /256, but the actual code just sets the first CS00
      bit of TCCR0B, which selects no prescaling.
      Now, we explicitly choose a prescale of clock_io/8, which seems to
      result in the desired behaviour. The brightness increases and decreases
      in equal increments, with no jumps with dead keypresses in between.
      There are now 1+8 brightness levels, that is, 'off' + 8 levels of
      brightness.
      Going any higher than a pwmval of 8 with these settings causes the
      backlight to blink, I believe due to overcurrent protection.
      11896702
    • Valtteri Koskivuori's avatar
      Tidy up backlight.c (No functional changes) · 28f1c2c8
      Valtteri Koskivuori authored
      This first commit just aims to make the keyboard backlight pwm setup
      code a bit more obvious, it's now broken up into sections, but the
      original behaviour is intact.
      The only functional change is, that each bit is now explicitly set to
      the intended value. It's my understanding that clearing a bit like
      this:
      value = (0 << offset);
      does not work. Instead, bitwise AND must be used, along with NOT, like
      so:
      value &= ~(1 << offset);
      
      It may be possible that this functional change affects behaviour, as
      those bits are now explicitly set to the intended value, but the
      behaviour observed is unchanged.
      28f1c2c8
  2. Oct 05, 2023
  3. Oct 03, 2023
  4. Sep 06, 2023
  5. Aug 29, 2023
  6. Aug 04, 2023
  7. Jul 27, 2023
  8. Jul 19, 2023
  9. Jul 18, 2023
  10. Jul 03, 2023
  11. Jun 29, 2023
  12. Jun 14, 2023
  13. Jun 07, 2023
    • Johannes Schauer Marin Rodrigues's avatar
      allow setting preprocessor variables from the outside · 064b49c2
      Johannes Schauer Marin Rodrigues authored
       - one no longer has to edit files to build different variants of the
         firmwares
       - set SOURCE_DATE_EPOCH to the date of the latest git commit for
         reproducibility
       - allow setting KBD_VARIANT_* from the outside
       - KBD_VARIANT_3_US and KBD_VARIANT_2_US set KBD_VARIANT_QWERTY_US
       - rename KBD_VARIANT_STANDALONE to KBD_MODE_STANDALONE
       - allow setting KBD_VARIANT_STANDALONE from the outside
       - build KBD_VARIANT_2 and KBD_VARIANT_3 with and without KBD_MODE_STANDALONE
         in the gitlab CI
       - allow setting KBD_FW_VERSION from the outside
       - set KBD_FW_REV to R2 for all variants and to R3 for KBD_VARIANT_3
       - rename REFORM_MBREV_R3 to REFORM_MBREV_20_R3
       - rename REFORM_MBREV_25_R1 to REFORM_MBREV_25_R2
       - allow setting REFORM_MOTHERBOARD_REV from the outside
       - pick FW_STRING2 depending on REFORM_MOTHERBOARD_REV
       - allow setting FW_STRING3 from the outside
       - build firmware on CI with git tag name in the version or commit hash
      064b49c2
  14. Jun 05, 2023
  15. May 31, 2023
  16. May 30, 2023
  17. May 16, 2023
Loading