Skip to content

Enable USB HID commands to address all 128 display columns

Valtteri Koskivuori requested to merge vkoskiv/reform:fix-hid-oled-width into master

The ColumnAddr (0x21) command in matrix_render_direct() was erroneously setting the column end address to 125 instead of 127, which made it impossible to address the rightmost two columns of pixels on the display from USB HID 'WBIT' commands.

The 126 pixel limit exists for text and graphics drawn by the keyboard firmware to simplify text drawing, since the firmware font width is 6px per character, and 126 / 6 == 21, a nice round number. I see no reason to impose this limit on arbitrary bitmap content drawn by commands from the operating system.

Merge request reports