Skip to content
Snippets Groups Projects
  1. Nov 06, 2013
  2. Jul 24, 2013
  3. May 14, 2013
  4. May 06, 2013
  5. Mar 06, 2012
  6. Jan 05, 2012
  7. Aug 01, 2011
  8. Oct 19, 2010
  9. Jul 24, 2010
  10. Jul 04, 2010
    • Wolfgang Denk's avatar
      Make sure that argv[] argument pointers are not modified. · 54841ab5
      Wolfgang Denk authored
      
      The hush shell dynamically allocates (and re-allocates) memory for the
      argument strings in the "char *argv[]" argument vector passed to
      commands.  Any code that modifies these pointers will cause serious
      corruption of the malloc data structures and crash U-Boot, so make
      sure the compiler can check that no such modifications are being done
      by changing the code into "char * const argv[]".
      
      This modification is the result of debugging a strange crash caused
      after adding a new command, which used the following argument
      processing code which has been working perfectly fine in all Unix
      systems since version 6 - but not so in U-Boot:
      
      int main (int argc, char **argv)
      {
      	while (--argc > 0 && **++argv == '-') {
      /* ====> */	while (*++*argv) {
      			switch (**argv) {
      			case 'd':
      				debug++;
      				break;
      			...
      			default:
      				usage ();
      			}
      		}
      	}
      	...
      }
      
      The line marked "====>" will corrupt the malloc data structures and
      usually cause U-Boot to crash when the next command gets executed by
      the shell.  With the modification, the compiler will prevent this with
      an
      	error: increment of read-only location '*argv'
      
      N.B.: The code above can be trivially rewritten like this:
      
      	while (--argc > 0 && **++argv == '-') {
      		char *arg = *argv;
      		while (*++arg) {
      			switch (*arg) {
      			...
      
      Signed-off-by: default avatarWolfgang Denk <wd@denx.de>
      Acked-by: default avatarMike Frysinger <vapier@gentoo.org>
      54841ab5
  11. Jun 12, 2009
    • Wolfgang Denk's avatar
      General help message cleanup · a89c33db
      Wolfgang Denk authored
      
      Many of the help messages were not really helpful; for example, many
      commands that take no arguments would not print a correct synopsis
      line, but "No additional help available." which is not exactly wrong,
      but not helpful either.
      
      Commit ``Make "usage" messages more helpful.'' changed this
      partially. But it also became clear that lots of "Usage" and "Help"
      messages (fields "usage" and "help" in struct cmd_tbl_s respective)
      were actually redundant.
      
      This patch cleans this up - for example:
      
      Before:
      	=> help dtt
      	dtt - Digital Thermometer and Thermostat
      
      	Usage:
      	dtt         - Read temperature from digital thermometer and thermostat.
      
      After:
      	=> help dtt
      	dtt - Read temperature from Digital Thermometer and Thermostat
      
      	Usage:
      	dtt
      
      Signed-off-by: default avatarWolfgang Denk <wd@denx.de>
      a89c33db
  12. Jan 28, 2009
  13. Jul 14, 2008
  14. Mar 12, 2008
  15. Feb 29, 2008
  16. Feb 25, 2008
    • Marian Balakowicz's avatar
      [new uImage] Add dual format uImage support framework · d5934ad7
      Marian Balakowicz authored
      
      This patch adds framework for dual format images. Format detection is added
      and the bootm controll flow is updated to include cases for new FIT format
      uImages.
      
      When the legacy (image_header based) format is detected appropriate
      legacy specific handling is invoked. For the new (FIT based) format uImages
      dual boot framework has a minial support, that will only print out a
      corresponding debug messages. Implementation of the FIT specific handling will
      be added in following patches.
      
      Signed-off-by: default avatarMarian Balakowicz <m8@semihalf.com>
      d5934ad7
  17. Feb 07, 2008
  18. Jan 09, 2008
  19. Nov 21, 2007
  20. Sep 25, 2007
  21. Jul 08, 2007
  22. Jul 03, 2007
  23. Oct 07, 2006
  24. Aug 15, 2006
  25. Oct 13, 2005
  26. Aug 10, 2005
  27. Aug 07, 2005
  28. Jan 22, 2005
  29. Jan 09, 2005
  30. Jan 03, 2004
  31. Jan 02, 2004
    • Wolfgang Denk's avatar
      * Cleanup lowboot code for MPC5200 · d4ca31c4
      Wolfgang Denk authored
      * Minor code cleanup (coding style)
      
      * Patch by Reinhard Meyer, 30 Dec 2003:
        - cpu/mpc5xxx/fec.c: added CONFIG_PHY_ADDR, added CONFIG_PHY_TYPE,
        - added CONFIG_PHY_ADDR to include/configs/IceCube.h,
        - turned debug print of PHY registers into a function (called in two places)
        - added support for EMK MPC5200 based modules
      
      * Fix MPC8xx PLPRCR_MFD_SHIFT typo
      
      * Add support for TQM866M modules
      
      * Fixes for TQM855M with 4 MB flash (Am29DL163 = _no_ mirror bit flash)
      
      * Fix a few compiler warnings
      d4ca31c4
  32. Dec 07, 2003
    • Wolfgang Denk's avatar
      * Patch by Pierre Aubert, 24 Nov 2003: · 9fd5e31f
      Wolfgang Denk authored
        - add a return value for the fpga command
        - add ide_preinit() function called in ide_init if CONFIG_IDE_PREINIT
          is defined. If ide_preinit fails, ide_init is aborted.
        - fix an endianess problem in fat.h
      9fd5e31f
  33. Jul 01, 2003
  34. Jun 29, 2003
  35. Jun 27, 2003
    • Wolfgang Denk's avatar
      * Code cleanup: · 8bde7f77
      Wolfgang Denk authored
        - remove trailing white space, trailing empty lines, C++ comments, etc.
        - split cmd_boot.c (separate cmd_bdinfo.c and cmd_load.c)
      
      * Patches by Kenneth Johansson, 25 Jun 2003:
        - major rework of command structure
          (work done mostly by Michal Cendrowski and Joakim Kristiansen)
      8bde7f77
Loading