Skip to content
Snippets Groups Projects
ddr3_pbs.c 42.9 KiB
Newer Older
  • Learn to ignore specific revisions
  • 1001 1002 1003 1004 1005 1006 1007 1008 1009 1010 1011 1012 1013 1014 1015 1016 1017 1018 1019 1020 1021 1022 1023 1024 1025 1026 1027 1028 1029 1030 1031 1032 1033 1034 1035 1036 1037 1038 1039 1040 1041 1042 1043 1044 1045 1046 1047 1048 1049 1050 1051 1052 1053 1054 1055 1056 1057 1058 1059 1060 1061 1062 1063 1064 1065 1066 1067 1068 1069 1070 1071 1072 1073 1074 1075 1076 1077 1078 1079 1080 1081 1082 1083 1084 1085 1086 1087 1088 1089 1090 1091 1092 1093 1094 1095 1096 1097 1098 1099 1100 1101 1102 1103 1104 1105 1106 1107 1108 1109 1110 1111 1112 1113 1114 1115 1116 1117 1118 1119 1120 1121 1122 1123 1124 1125 1126 1127 1128 1129 1130 1131 1132 1133 1134 1135 1136 1137 1138 1139 1140 1141 1142 1143 1144 1145 1146 1147 1148 1149 1150 1151 1152 1153 1154 1155 1156 1157 1158 1159 1160 1161 1162 1163 1164 1165 1166 1167 1168 1169 1170 1171 1172 1173 1174 1175 1176 1177 1178 1179 1180 1181 1182 1183 1184 1185 1186 1187 1188 1189 1190 1191 1192 1193 1194 1195 1196 1197 1198 1199 1200 1201 1202 1203 1204 1205 1206 1207 1208 1209 1210 1211 1212 1213 1214 1215 1216 1217 1218 1219 1220 1221 1222 1223 1224 1225 1226 1227 1228 1229 1230 1231 1232 1233 1234 1235 1236 1237 1238 1239 1240 1241 1242 1243 1244 1245 1246 1247 1248 1249 1250 1251 1252 1253 1254 1255 1256 1257 1258 1259 1260 1261 1262 1263 1264 1265 1266 1267 1268 1269 1270 1271 1272 1273 1274 1275 1276 1277 1278 1279 1280 1281 1282 1283 1284 1285 1286 1287 1288 1289 1290 1291 1292 1293 1294 1295 1296 1297 1298 1299 1300 1301 1302 1303 1304 1305 1306 1307 1308 1309 1310 1311 1312 1313 1314 1315 1316 1317 1318 1319 1320 1321 1322 1323 1324 1325 1326 1327 1328 1329 1330 1331 1332 1333 1334 1335 1336 1337 1338 1339 1340 1341 1342 1343 1344 1345 1346 1347 1348 1349 1350 1351 1352 1353 1354 1355 1356 1357 1358 1359 1360 1361 1362 1363 1364 1365 1366 1367 1368 1369 1370 1371 1372 1373 1374 1375 1376 1377 1378 1379 1380 1381 1382 1383 1384 1385 1386 1387 1388 1389 1390 1391 1392 1393 1394 1395 1396 1397 1398 1399 1400 1401 1402 1403 1404 1405 1406 1407 1408 1409 1410 1411 1412 1413 1414 1415 1416 1417 1418 1419 1420 1421 1422 1423 1424 1425 1426 1427 1428 1429 1430 1431 1432 1433 1434 1435 1436 1437 1438 1439 1440 1441 1442 1443 1444 1445 1446 1447 1448 1449 1450 1451 1452 1453 1454 1455 1456 1457 1458 1459 1460 1461 1462 1463 1464 1465 1466 1467 1468 1469 1470 1471 1472 1473 1474 1475 1476 1477 1478 1479 1480 1481 1482 1483 1484 1485 1486 1487 1488 1489 1490 1491 1492 1493 1494 1495 1496 1497 1498 1499 1500 1501 1502 1503 1504 1505 1506 1507 1508 1509 1510 1511 1512 1513 1514 1515 1516 1517 1518 1519 1520 1521 1522 1523 1524 1525 1526 1527 1528 1529 1530 1531 1532 1533 1534 1535 1536 1537 1538 1539 1540 1541 1542 1543 1544 1545 1546 1547 1548 1549 1550 1551 1552 1553 1554 1555 1556 1557 1558 1559 1560 1561 1562 1563 1564 1565 1566 1567 1568 1569 1570 1571 1572 1573 1574 1575 1576 1577 1578 1579 1580 1581 1582 1583 1584 1585 1586 1587 1588 1589 1590 1591 1592
    		}
    
    		DEBUG_PBS_FULL_S("DDR3 - PBS RX - Shift DQS - Inc DQS deskew for PUPs: ");
    		DEBUG_PBS_FULL_D(unlock_pup, 2);
    		DEBUG_PBS_FULL_C(", deskew = ", dqs_deskew_val, 2);
    
    		/* Increment DQS deskew elements - Only for unlocked pups */
    		dqs_deskew_val++;
    		for (pup = 0; pup < cur_max_pup; pup++) {
    			if (IS_PUP_ACTIVE(unlock_pup, pup) == 1) {
    				ddr3_write_pup_reg(PUP_PBS_RX + DQS_DQ_NUM, CS0,
    						   pup + ecc * ECC_PUP, 0,
    						   dqs_deskew_val);
    			}
    		}
    	} while (1);
    
    	DEBUG_PBS_FULL_S("DDR3 - PBS RX - Shift DQS - ADLL shift one step before fail\n");
    	/* Continue to ADLL shift one step before fail */
    	unlock_pup = cur_pup;
    	do {
    		/* Loop until pass compare for all pups */
    		new_lockup_pup = 0;
    		/* Read and compare results  */
    		if (MV_OK != ddr3_sdram_compare(dram_info, unlock_pup, &new_lockup_pup,
    						pattern_ptr, LEN_PBS_PATTERN,
    						SDRAM_PBS_I_OFFS +
    						pbs_pattern_idx * SDRAM_PBS_NEXT_OFFS,
    						1, 0, NULL, 0)) {
    			DEBUG_PBS_S("DDR3 - PBS Rx - Shift DQS - MV_DDR3_TRAINING_ERR_PBS_SHIFT_QDS_SRAM_CMP(ddr3_sdram_compare)\n");
    			return MV_DDR3_TRAINING_ERR_PBS_SHIFT_QDS_SRAM_CMP;
    		}
    
    		/*
    		 * Get mask for pup which passed so their adll will be
    		 * changed to 2 steps before fails
    		 */
    		pass_pup = unlock_pup & ~new_lockup_pup;
    
    		DEBUG_PBS_FULL_S("Shift DQS by 2 steps for PUPs: ");
    		DEBUG_PBS_FULL_D(pass_pup, 2);
    		DEBUG_PBS_FULL_C(", Set ADLL value = ", (adll_val - 2), 2);
    
    		/* Only for pass pups   */
    		for (pup = 0; pup < cur_max_pup; pup++) {
    			if (IS_PUP_ACTIVE(pass_pup, pup) == 1) {
    				ddr3_write_pup_reg(PUP_DQS_RD, CS0,
    						   pup + ecc * ECC_PUP, 0,
    						   (adll_val - 2));
    			}
    		}
    
    		/* Locked pups that compare success  */
    		unlock_pup &= new_lockup_pup;
    
    		if (unlock_pup == 0) {
    			/* All pups locked */
    			break;
    		}
    
    		/* Found error */
    		if (adll_val == 0) {
    			DEBUG_PBS_FULL_S("DDR3 - PBS Rx - Shift DQS - Adll reach min value\n");
    			return MV_DDR3_TRAINING_ERR_PBS_SHIFT_QDS_MAX_VAL;
    		}
    
    		/*
    		 * Decrement (Move Back to Left one phase - ADLL) dqs RX delay
    		 */
    		adll_val--;
    		for (pup = 0; pup < cur_max_pup; pup++) {
    			if (IS_PUP_ACTIVE(unlock_pup, pup) == 1) {
    				ddr3_write_pup_reg(PUP_DQS_RD, CS0,
    						   pup + ecc * ECC_PUP, 0,
    						   adll_val);
    			}
    		}
    	} while (1);
    
    	return MV_OK;
    }
    
    /*
     * lock_pups() extracted from ddr3_pbs_per_bit(). This just got too
     * much indented making it hard to read / edit.
     */
    static void lock_pups(u32 pup, u32 *pup_locked, u8 *unlock_pup_dq_array,
    		      u32 pbs_curr_val, u32 start_pbs, u32 ecc, int is_tx)
    {
    	u32 dq;
    	int idx;
    
    	/* Lock PBS value for all remaining PUPs bits */
    	DEBUG_PBS_FULL_S("DDR3 - PBS Per bit - Lock PBS value for all remaining PUPs bits, pup ");
    	DEBUG_PBS_FULL_D(pup, 1);
    	DEBUG_PBS_FULL_C(" pbs value ", pbs_curr_val, 2);
    
    	idx = pup * (1 - ecc) + ecc * ECC_PUP;
    	*pup_locked &= ~(1 << pup);
    
    	for (dq = 0; dq < DQ_NUM; dq++) {
    		if (IS_PUP_ACTIVE(unlock_pup_dq_array[dq], pup) == 1) {
    			int offs;
    
    			/* Lock current dq */
    			unlock_pup_dq_array[dq] &= ~(1 << pup);
    			skew_array[(pup * DQ_NUM) + dq] = pbs_curr_val;
    
    			if (is_tx == 1)
    				offs = PUP_PBS_TX;
    			else
    				offs = PUP_PBS_RX;
    
    			ddr3_write_pup_reg(offs +
    					   pbs_dq_mapping[idx][dq], CS0,
    					   idx, 0, start_pbs);
    		}
    	}
    }
    
    /*
     * Name:     ddr3_pbs_per_bit
     * Desc:     Execute the Per Bit Skew phase.
     * Args:     start_over      Return whether need to start over the algorithm
     *           is_tx           Indicate whether Rx or Tx
     *           pcur_pup        bit array of the function active pups. return the
     *                           pups that need to repeat on the PBS
     *           pbs_pattern_idx Index of PBS pattern
     *
     * Notes:    Current implementation supports double activation of this function.
     *           i.e. in order to activate this function (using start_over) more than
     *           twice, the implementation should change.
     *           imlementation limitation are marked using
     *           ' CHIP-ONLY! - Implementation Limitation '
     * Returns:  MV_OK if success, other error code if fail.
     */
    static int ddr3_pbs_per_bit(MV_DRAM_INFO *dram_info, int *start_over, int is_tx,
    			    u32 *pcur_pup, u32 pbs_pattern_idx, u32 ecc)
    {
    	/*
    	 * Bit array to indicate if we already get fail on bit per pup & dq bit
    	 */
    	u8 unlock_pup_dq_array[DQ_NUM] = {
    		*pcur_pup, *pcur_pup, *pcur_pup, *pcur_pup, *pcur_pup,
    		*pcur_pup, *pcur_pup, *pcur_pup
    	};
    
    	u8 cmp_unlock_pup_dq_array[COUNT_PBS_COMP_RETRY_NUM][DQ_NUM];
    	u32 pup, dq;
    	/* value of pbs is according to RX or TX */
    	u32 start_pbs, last_pbs;
    	u32 pbs_curr_val;
    	/* bit array that indicates all dq of the pup locked */
    	u32 pup_locked;
    	u32 first_fail[MAX_PUP_NUM] = { 0 };	/* count first fail per pup */
    	/* indicates whether we get first fail per pup */
    	int first_failed[MAX_PUP_NUM] = { 0 };
    	/* bit array that indicates pup already get fail */
    	u32 sum_pup_fail;
    	/* use to calculate diff between curr pbs to first fail pbs */
    	u32 calc_pbs_diff;
    	u32 pbs_cmp_retry;
    	u32 max_pup;
    
    	/* Set init values for retry array - 8 retry */
    	for (pbs_cmp_retry = 0; pbs_cmp_retry < COUNT_PBS_COMP_RETRY_NUM;
    	     pbs_cmp_retry++) {
    		for (dq = 0; dq < DQ_NUM; dq++)
    			cmp_unlock_pup_dq_array[pbs_cmp_retry][dq] = *pcur_pup;
    	}
    
    	memset(&skew_array, 0, MAX_PUP_NUM * DQ_NUM * sizeof(u32));
    
    	DEBUG_PBS_FULL_S("DDR3 - PBS Per bit - Started\n");
    
    	/* The pbs value depends if rx or tx */
    	if (is_tx == 1) {
    		start_pbs = MIN_PBS;
    		last_pbs = MAX_PBS;
    	} else {
    		start_pbs = MAX_PBS;
    		last_pbs = MIN_PBS;
    	}
    
    	pbs_curr_val = start_pbs;
    	pup_locked = *pcur_pup;
    
    	/* Set current pup number */
    	if (pup_locked == 0x1)	/* Ecc mode */
    		max_pup = 1;
    	else
    		max_pup = dram_info->num_of_std_pups;
    
    	do {
    		/* Increment/ decrement PBS for un-lock bits only */
    		if (is_tx == 1)
    			pbs_curr_val++;
    		else
    			pbs_curr_val--;
    
    		/* Set Current PBS delay  */
    		for (dq = 0; dq < DQ_NUM; dq++) {
    			/* Check DQ bits to see if locked in all pups */
    			if (unlock_pup_dq_array[dq] == 0) {
    				DEBUG_PBS_FULL_S("DDR3 - PBS Per bit - All pups are locked for DQ ");
    				DEBUG_PBS_FULL_D(dq, 1);
    				DEBUG_PBS_FULL_S("\n");
    				continue;
    			}
    
    			for (pup = 0; pup < max_pup; pup++) {
    				int idx;
    
    				idx = pup * (1 - ecc) + ecc * ECC_PUP;
    
    				if (IS_PUP_ACTIVE(unlock_pup_dq_array[dq], pup)
    				    == 0)
    					continue;
    
    				if (is_tx == 1)
    					ddr3_write_pup_reg(
    						PUP_PBS_TX + pbs_dq_mapping[idx][dq],
    						CS0, idx, 0, pbs_curr_val);
    				else
    					ddr3_write_pup_reg(
    						PUP_PBS_RX + pbs_dq_mapping[idx][dq],
    						CS0, idx, 0, pbs_curr_val);
    			}
    		}
    
    		/*
    		 * Write Read and compare results - run the test
    		 * DDR_PBS_COMP_RETRY_NUM times
    		 */
    		/* Run number of read and write to verify */
    		for (pbs_cmp_retry = 0;
    		     pbs_cmp_retry < COUNT_PBS_COMP_RETRY_NUM;
    		     pbs_cmp_retry++) {
    
    			if (MV_OK !=
    			    ddr3_sdram_pbs_compare(dram_info, pup_locked, is_tx,
    						   pbs_pattern_idx,
    						   pbs_curr_val, start_pbs,
    						   skew_array,
    						   cmp_unlock_pup_dq_array
    						   [pbs_cmp_retry], ecc))
    				return MV_FAIL;
    
    			for (pup = 0; pup < max_pup; pup++) {
    				for (dq = 0; dq < DQ_NUM; dq++) {
    					if ((IS_PUP_ACTIVE(unlock_pup_dq_array[dq],
    							   pup) == 1)
    					    && (IS_PUP_ACTIVE(cmp_unlock_pup_dq_array
    					      [pbs_cmp_retry][dq],
    					      pup) == 0)) {
    						DEBUG_PBS_FULL_S("DDR3 - PBS Per bit - PbsCurrVal: ");
    						DEBUG_PBS_FULL_D(pbs_curr_val, 2);
    						DEBUG_PBS_FULL_S(" PUP: ");
    						DEBUG_PBS_FULL_D(pup, 1);
    						DEBUG_PBS_FULL_S(" DQ: ");
    						DEBUG_PBS_FULL_D(dq, 1);
    						DEBUG_PBS_FULL_S(" - failed\n");
    					}
    				}
    			}
    
    			for (dq = 0; dq < DQ_NUM; dq++) {
    				unlock_pup_dq_array[dq] &=
    				    cmp_unlock_pup_dq_array[pbs_cmp_retry][dq];
    			}
    		}
    
    		pup_locked = 0;
    		sum_pup_fail = *pcur_pup;
    
    		/* Check which DQ is failed */
    		for (dq = 0; dq < DQ_NUM; dq++) {
    			/* Summarize the locked pup */
    			pup_locked |= unlock_pup_dq_array[dq];
    
    			/* Check if get fail */
    			sum_pup_fail &= unlock_pup_dq_array[dq];
    		}
    
    		/* If all PUPS are locked in all DQ - Break */
    		if (pup_locked == 0) {
    			/* All pups are locked */
    			*start_over = 0;
    			DEBUG_PBS_FULL_S("DDR3 - PBS Per bit -  All bit in all pups are successfully locked\n");
    			break;
    		}
    
    		/* PBS deskew elements reach max ? */
    		if (pbs_curr_val == last_pbs) {
    			DEBUG_PBS_FULL_S("DDR3 - PBS Per bit - PBS deskew elements reach max\n");
    			/* CHIP-ONLY! - Implementation Limitation */
    			*start_over = (sum_pup_fail != 0) && (!(*start_over));
    			*pcur_pup = pup_locked;
    
    			DEBUG_PBS_FULL_S("DDR3 - PBS Per bit - StartOver: ");
    			DEBUG_PBS_FULL_D(*start_over, 1);
    			DEBUG_PBS_FULL_S("  pup_locked: ");
    			DEBUG_PBS_FULL_D(pup_locked, 2);
    			DEBUG_PBS_FULL_S("  sum_pup_fail: ");
    			DEBUG_PBS_FULL_D(sum_pup_fail, 2);
    			DEBUG_PBS_FULL_S("\n");
    
    			/* Lock PBS value for all remaining  bits */
    			for (pup = 0; pup < max_pup; pup++) {
    				/* Check if current pup already received error */
    				if (IS_PUP_ACTIVE(pup_locked, pup) == 1) {
    					/* Valid pup for current function */
    					if (IS_PUP_ACTIVE(sum_pup_fail, pup) ==
    					    1 && (*start_over == 1)) {
    						DEBUG_PBS_FULL_C("DDR3 - PBS Per bit - skipping lock of pup (first loop of pbs)",
    								 pup, 1);
    						continue;
    					} else
    					    if (IS_PUP_ACTIVE(sum_pup_fail, pup)
    						== 1) {
    						DEBUG_PBS_FULL_C("DDR3 - PBS Per bit - Locking pup %d (even though it wasn't supposed to be locked)",
    								 pup, 1);
    					}
    
    					/* Already got fail on the PUP */
    					/* Lock PBS value for all remaining bits */
    					DEBUG_PBS_FULL_S("DDR3 - PBS Per bit - Locking remaning DQs for pup - ");
    					DEBUG_PBS_FULL_D(pup, 1);
    					DEBUG_PBS_FULL_S(": ");
    
    					for (dq = 0; dq < DQ_NUM; dq++) {
    						if (IS_PUP_ACTIVE
    						    (unlock_pup_dq_array[dq],
    						     pup) == 1) {
    							DEBUG_PBS_FULL_D(dq, 1);
    							DEBUG_PBS_FULL_S(",");
    							/* set current PBS */
    							skew_array[((pup) *
    								    DQ_NUM) +
    								   dq] =
    							    pbs_curr_val;
    						}
    					}
    
    					if (*start_over == 1) {
    						/*
    						 * Reset this pup bit - when
    						 * restart the PBS, ignore this
    						 * pup
    						 */
    						*pcur_pup &= ~(1 << pup);
    					}
    					DEBUG_PBS_FULL_S("\n");
    				} else {
    					DEBUG_PBS_FULL_S("DDR3 - PBS Per bit - Pup ");
    					DEBUG_PBS_FULL_D(pup, 1);
    					DEBUG_PBS_FULL_C(" is not set in puplocked - ",
    							 pup_locked, 1);
    				}
    			}
    
    			/* Need to start the PBS again */
    			if (*start_over == 1) {
    				DEBUG_PBS_FULL_S("DDR3 - PBS Per bit - false fail - returning to start\n");
    				return MV_OK;
    			}
    			break;
    		}
    
    		/* Diff Check */
    		for (pup = 0; pup < max_pup; pup++) {
    			if (IS_PUP_ACTIVE(pup_locked, pup) == 1) {
    				/* pup is not locked */
    				if (first_failed[pup] == 0) {
    					/* No first fail until now */
    					if (IS_PUP_ACTIVE(sum_pup_fail, pup) ==
    					    0) {
    						/* Get first fail */
    						DEBUG_PBS_FULL_C("DDR3 - PBS Per bit - First fail in pup ",
    								 pup, 1);
    						first_failed[pup] = 1;
    						first_fail[pup] = pbs_curr_val;
    					}
    				} else {
    					/* Already got first fail */
    					if (is_tx == 1) {
    						/* TX - inc pbs */
    						calc_pbs_diff =	pbs_curr_val -
    							first_fail[pup];
    					} else {
    						/* RX - dec pbs */
    						calc_pbs_diff = first_fail[pup] -
    							pbs_curr_val;
    					}
    
    					if (calc_pbs_diff >= PBS_DIFF_LIMIT) {
    						lock_pups(pup, &pup_locked,
    							  unlock_pup_dq_array,
    							  pbs_curr_val,
    							  start_pbs, ecc, is_tx);
    					}
    				}
    			}
    		}
    	} while (1);
    
    	return MV_OK;
    }
    
    /*
     * Name:         ddr3_set_pbs_results
     * Desc:         Set to HW the PBS phase results.
     * Args:         is_tx       Indicates whether to set Tx or RX results
     * Notes:
     * Returns:      MV_OK if success, other error code if fail.
     */
    static int ddr3_set_pbs_results(MV_DRAM_INFO *dram_info, int is_tx)
    {
    	u32 pup, phys_pup, dq;
    	u32 max_pup;		/* number of valid pups */
    	u32 pbs_min;		/* minimal pbs val per pup */
    	u32 pbs_max;		/* maximum pbs val per pup */
    	u32 val[9];
    
    	max_pup = dram_info->num_of_total_pups;
    	DEBUG_PBS_FULL_S("DDR3 - PBS - ddr3_set_pbs_results:\n");
    
    	/* Loop for all dqs & pups */
    	for (pup = 0; pup < max_pup; pup++) {
    		if (pup == (max_pup - 1) && dram_info->ecc_ena)
    			phys_pup = ECC_PUP;
    		else
    			phys_pup = pup;
    
    		/*
    		 * To minimize delay elements, inc from pbs value the min
    		 * pbs val
    		 */
    		pbs_min = MAX_PBS;
    		pbs_max = 0;
    		for (dq = 0; dq < DQ_NUM; dq++) {
    			if (pbs_min > skew_array[(pup * DQ_NUM) + dq])
    				pbs_min = skew_array[(pup * DQ_NUM) + dq];
    
    			if (pbs_max < skew_array[(pup * DQ_NUM) + dq])
    				pbs_max = skew_array[(pup * DQ_NUM) + dq];
    		}
    
    		pbs_max -= pbs_min;
    
    		DEBUG_PBS_FULL_S("DDR3 - PBS - PUP");
    		DEBUG_PBS_FULL_D(phys_pup, 1);
    		DEBUG_PBS_FULL_S(": Min Val = ");
    		DEBUG_PBS_FULL_D(pbs_min, 2);
    		DEBUG_PBS_FULL_C(", Max Val = ", pbs_max, 2);
    
    		val[pup] = 0;
    
    		for (dq = 0; dq < DQ_NUM; dq++) {
    			int idx;
    			int offs;
    
    			/* Set skew value for all dq */
    			/*
    			 * Bit# Deskew <- Bit# Deskew - last / first
    			 * failing bit Deskew For all bits (per PUP)
    			 * (minimize delay elements)
    			 */
    
    			DEBUG_PBS_FULL_S("DQ");
    			DEBUG_PBS_FULL_D(dq, 1);
    			DEBUG_PBS_FULL_S("-");
    			DEBUG_PBS_FULL_D((skew_array[(pup * DQ_NUM) + dq] -
    					  pbs_min), 2);
    			DEBUG_PBS_FULL_S(", ");
    
    			idx = (pup * DQ_NUM) + dq;
    
    			if (is_tx == 1)
    				offs = PUP_PBS_TX;
    			else
    				offs = PUP_PBS_RX;
    
    			ddr3_write_pup_reg(offs + pbs_dq_mapping[phys_pup][dq],
    					   CS0, phys_pup, 0,
    					   skew_array[idx] - pbs_min);
    
    			if (is_tx == 1)
    				val[pup] += skew_array[idx] - pbs_min;
    		}
    
    		DEBUG_PBS_FULL_S("\n");
    
    		/* Set the DQS the half of the Max PBS of the DQs  */
    		if (is_tx == 1) {
    			ddr3_write_pup_reg(PUP_PBS_TX + 8, CS0, phys_pup, 0,
    					   pbs_max / 2);
    			ddr3_write_pup_reg(PUP_PBS_TX + 0xa, CS0, phys_pup, 0,
    					   val[pup] / 8);
    		} else
    			ddr3_write_pup_reg(PUP_PBS_RX + 8, CS0, phys_pup, 0,
    					   pbs_max / 2);
    	}
    
    	return MV_OK;
    }
    
    static void ddr3_pbs_write_pup_dqs_reg(u32 cs, u32 pup, u32 dqs_delay)
    {
    	u32 reg, delay;
    
    	reg = (ddr3_read_pup_reg(PUP_WL_MODE, cs, pup) & 0x3FF);
    	delay = reg & PUP_DELAY_MASK;
    	reg |= ((dqs_delay + delay) << REG_PHY_DQS_REF_DLY_OFFS);
    	reg |= REG_PHY_REGISTRY_FILE_ACCESS_OP_WR;
    	reg |= (pup << REG_PHY_PUP_OFFS);
    	reg |= ((0x4 * cs + PUP_WL_MODE) << REG_PHY_CS_OFFS);
    
    	reg_write(REG_PHY_REGISTRY_FILE_ACCESS_ADDR, reg);	/* 0x16A0 */
    	do {
    		reg = reg_read(REG_PHY_REGISTRY_FILE_ACCESS_ADDR) &
    			REG_PHY_REGISTRY_FILE_ACCESS_OP_DONE;
    	} while (reg);	/* Wait for '0' to mark the end of the transaction */
    
    	udelay(10);
    }
    
    /*
     * Set training patterns
     */
    int ddr3_load_pbs_patterns(MV_DRAM_INFO *dram_info)
    {
    	u32 cs, cs_count, cs_tmp;
    	u32 sdram_addr;
    	u32 *pattern_ptr0, *pattern_ptr1;
    
    	/* Choose pattern */
    	switch (dram_info->ddr_width) {
    #if defined(MV88F672X)
    	case 16:
    		pattern_ptr0 = (u32 *)&pbs_pattern[0];
    		pattern_ptr1 = (u32 *)&pbs_pattern[1];
    		break;
    #endif
    	case 32:
    		pattern_ptr0 = (u32 *)&pbs_pattern_32b[0];
    		pattern_ptr1 = (u32 *)&pbs_pattern_32b[1];
    		break;
    #if defined(MV88F78X60)
    	case 64:
    		pattern_ptr0 = (u32 *)&pbs_pattern_64b[0];
    		pattern_ptr1 = (u32 *)&pbs_pattern_64b[1];
    		break;
    #endif
    	default:
    		return MV_FAIL;
    	}
    
    	/* Loop for each CS */
    	for (cs = 0; cs < MAX_CS; cs++) {
    		if (dram_info->cs_ena & (1 << cs)) {
    			cs_count = 0;
    			for (cs_tmp = 0; cs_tmp < cs; cs_tmp++) {
    				if (dram_info->cs_ena & (1 << cs_tmp))
    					cs_count++;
    			}
    
    			/* Init PBS I pattern */
    			sdram_addr = (cs_count * (SDRAM_CS_SIZE + 1) +
    				      SDRAM_PBS_I_OFFS);
    			if (MV_OK !=
    			    ddr3_sdram_compare(dram_info, (u32) NULL, NULL,
    					       pattern_ptr0, LEN_STD_PATTERN,
    					       sdram_addr, 1, 0, NULL,
    					       0))
    				return MV_FAIL;
    
    			/* Init PBS II pattern */
    			sdram_addr = (cs_count * (SDRAM_CS_SIZE + 1) +
    				      SDRAM_PBS_II_OFFS);
    			if (MV_OK !=
    			    ddr3_sdram_compare(dram_info, (u32) NULL, NULL,
    					       pattern_ptr1, LEN_STD_PATTERN,
    					       sdram_addr, 1, 0, NULL,
    					       0))
    				return MV_FAIL;
    		}
    	}
    
    	return MV_OK;
    }
    #endif