Skip to content
Snippets Groups Projects
ddr3_pbs.c 42.9 KiB
Newer Older
  • Learn to ignore specific revisions
  • 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435 436 437 438 439 440 441 442 443 444 445 446 447 448 449 450 451 452 453 454 455 456 457 458 459 460 461 462 463 464 465 466 467 468 469 470 471 472 473 474 475 476 477 478 479 480 481 482 483 484 485 486 487 488 489 490 491 492 493 494 495 496 497 498 499 500 501 502 503 504 505 506 507 508 509 510 511 512 513 514 515 516 517 518 519 520 521 522 523 524 525 526 527 528 529 530 531 532 533 534 535 536 537 538 539 540 541 542 543 544 545 546 547 548 549 550 551 552 553 554 555 556 557 558 559 560 561 562 563 564 565 566 567 568 569 570 571 572 573 574 575 576 577 578 579 580 581 582 583 584 585 586 587 588 589 590 591 592 593 594 595 596 597 598 599 600 601 602 603 604 605 606 607 608 609 610 611 612 613 614 615 616 617 618 619 620 621 622 623 624 625 626 627 628 629 630 631 632 633 634 635 636 637 638 639 640 641 642 643 644 645 646 647 648 649 650 651 652 653 654 655 656 657 658 659 660 661 662 663 664 665 666 667 668 669 670 671 672 673 674 675 676 677 678 679 680 681 682 683 684 685 686 687 688 689 690 691 692 693 694 695 696 697 698 699 700 701 702 703 704 705 706 707 708 709 710 711 712 713 714 715 716 717 718 719 720 721 722 723 724 725 726 727 728 729 730 731 732 733 734 735 736 737 738 739 740 741 742 743 744 745 746 747 748 749 750 751 752 753 754 755 756 757 758 759 760 761 762 763 764 765 766 767 768 769 770 771 772 773 774 775 776 777 778 779 780 781 782 783 784 785 786 787 788 789 790 791 792 793 794 795 796 797 798 799 800 801 802 803 804 805 806 807 808 809 810 811 812 813 814 815 816 817 818 819 820 821 822 823 824 825 826 827 828 829 830 831 832 833 834 835 836 837 838 839 840 841 842 843 844 845 846 847 848 849 850 851 852 853 854 855 856 857 858 859 860 861 862 863 864 865 866 867 868 869 870 871 872 873 874 875 876 877 878 879 880 881 882 883 884 885 886 887 888 889 890 891 892 893 894 895 896 897 898 899 900 901 902 903 904 905 906 907 908 909 910 911 912 913 914 915 916 917 918 919 920 921 922 923 924 925 926 927 928 929 930 931 932 933 934 935 936 937 938 939 940 941 942 943 944 945 946 947 948 949 950 951 952 953 954 955 956 957 958 959 960 961 962 963 964 965 966 967 968 969 970 971 972 973 974 975 976 977 978 979 980 981 982 983 984 985 986 987 988 989 990 991 992 993 994 995 996 997 998 999 1000
    /*
     * Copyright (C) Marvell International Ltd. and its affiliates
     *
     * SPDX-License-Identifier:	GPL-2.0
     */
    
    #include <common.h>
    #include <i2c.h>
    #include <spl.h>
    #include <asm/io.h>
    #include <asm/arch/cpu.h>
    #include <asm/arch/soc.h>
    
    #include "ddr3_hw_training.h"
    
    /*
     * Debug
     */
    #define DEBUG_PBS_FULL_C(s, d, l) \
    	DEBUG_PBS_FULL_S(s); DEBUG_PBS_FULL_D(d, l); DEBUG_PBS_FULL_S("\n")
    #define DEBUG_PBS_C(s, d, l) \
    	DEBUG_PBS_S(s); DEBUG_PBS_D(d, l); DEBUG_PBS_S("\n")
    
    #ifdef MV_DEBUG_PBS
    #define DEBUG_PBS_S(s)			puts(s)
    #define DEBUG_PBS_D(d, l)		printf("%x", d)
    #else
    #define DEBUG_PBS_S(s)
    #define DEBUG_PBS_D(d, l)
    #endif
    
    #ifdef MV_DEBUG_FULL_PBS
    #define DEBUG_PBS_FULL_S(s)		puts(s)
    #define DEBUG_PBS_FULL_D(d, l)		printf("%x", d)
    #else
    #define DEBUG_PBS_FULL_S(s)
    #define DEBUG_PBS_FULL_D(d, l)
    #endif
    
    #if defined(MV88F78X60) || defined(MV88F672X)
    
    /* Temp array for skew data storage */
    static u32 skew_array[(MAX_PUP_NUM) * DQ_NUM] = { 0 };
    
    /* PBS locked dq (per pup) */
    extern u32 pbs_locked_dq[MAX_PUP_NUM][DQ_NUM];
    extern u32 pbs_locked_dm[MAX_PUP_NUM];
    extern u32 pbs_locked_value[MAX_PUP_NUM][DQ_NUM];
    
    #if defined(MV88F672X)
    extern u32 pbs_pattern[2][LEN_16BIT_PBS_PATTERN];
    extern u32 pbs_pattern_32b[2][LEN_PBS_PATTERN];
    #else
    extern u32 pbs_pattern_32b[2][LEN_PBS_PATTERN];
    extern u32 pbs_pattern_64b[2][LEN_PBS_PATTERN];
    #endif
    
    extern u32 pbs_dq_mapping[PUP_NUM_64BIT + 1][DQ_NUM];
    
    static int ddr3_tx_shift_dqs_adll_step_before_fail(MV_DRAM_INFO *dram_info,
    		u32 cur_pup, u32 pbs_pattern_idx, u32 ecc);
    static int ddr3_rx_shift_dqs_to_first_fail(MV_DRAM_INFO *dram_info, u32 cur_pup,
    		u32 pbs_pattern_idx, u32 ecc);
    static int ddr3_pbs_per_bit(MV_DRAM_INFO *dram_info, int *start_over, int is_tx,
    		u32 *pcur_pup, u32 pbs_pattern_idx, u32 ecc);
    static int ddr3_set_pbs_results(MV_DRAM_INFO *dram_info, int is_tx);
    static void ddr3_pbs_write_pup_dqs_reg(u32 cs, u32 pup, u32 dqs_delay);
    
    /*
     * Name:     ddr3_pbs_tx
     * Desc:     Execute the PBS TX phase.
     * Args:     dram_info   ddr3 training information struct
     * Notes:
     * Returns:  MV_OK if success, other error code if fail.
     */
    int ddr3_pbs_tx(MV_DRAM_INFO *dram_info)
    {
    	/* Array of Deskew results */
    
    	/*
    	 * Array to hold the total sum of skew from all iterations
    	 * (for average purpose)
    	 */
    	u32 skew_sum_array[MAX_PUP_NUM][DQ_NUM] = { {0} };
    
    	/*
    	 * Array to hold the total average skew from both patterns
    	 * (for average purpose)
    	 */
    	u32 pattern_skew_array[MAX_PUP_NUM][DQ_NUM] = { {0} };
    
    	u32 pbs_rep_time = 0;	/* counts number of loop in case of fail */
    	/* bit array for unlock pups - used to repeat on the RX operation */
    	u32 cur_pup;
    	u32 max_pup;
    	u32 pbs_retry;
    	u32 pup, dq, pups, cur_max_pup, valid_pup, reg;
    	u32 pattern_idx;
    	u32 ecc;
    	/* indicates whether we need to start the loop again */
    	int start_over;
    
    	DEBUG_PBS_S("DDR3 - PBS TX - Starting PBS TX procedure\n");
    
    	pups = dram_info->num_of_total_pups;
    	max_pup = dram_info->num_of_total_pups;
    
    	/* Enable SW override */
    	reg = reg_read(REG_DRAM_TRAINING_2_ADDR) |
    		(1 << REG_DRAM_TRAINING_2_SW_OVRD_OFFS);
    	/* [0] = 1 - Enable SW override  */
    	/* 0x15B8 - Training SW 2 Register */
    	reg_write(REG_DRAM_TRAINING_2_ADDR, reg);
    	DEBUG_PBS_S("DDR3 - PBS RX - SW Override Enabled\n");
    
    	reg = 1 << REG_DRAM_TRAINING_AUTO_OFFS;
    	reg_write(REG_DRAM_TRAINING_ADDR, reg);	/* 0x15B0 - Training Register */
    
    	/* Running twice for 2 different patterns. each patterns - 3 times */
    	for (pattern_idx = 0; pattern_idx < COUNT_PBS_PATTERN; pattern_idx++) {
    		DEBUG_PBS_C("DDR3 - PBS TX - Working with pattern - ",
    			    pattern_idx, 1);
    
    		/* Reset sum array */
    		for (pup = 0; pup < pups; pup++) {
    			for (dq = 0; dq < DQ_NUM; dq++)
    				skew_sum_array[pup][dq] = 0;
    		}
    
    		/*
    		 * Perform PBS several of times (3 for each pattern).
    		 * At the end, we'll use the average
    		 */
    		/* If there is ECC, do each PBS again with mux change */
    		for (pbs_retry = 0; pbs_retry < COUNT_PBS_REPEAT; pbs_retry++) {
    			for (ecc = 0; ecc < (dram_info->ecc_ena + 1); ecc++) {
    
    				/*
    				 * This parameter stores the current PUP
    				 * num - ecc mode dependent - 4-8 / 1 pups
    				 */
    				cur_max_pup = (1 - ecc) *
    					dram_info->num_of_std_pups + ecc;
    
    				if (ecc) {
    					/* Only 1 pup in this case */
    					valid_pup = 0x1;
    				} else if (cur_max_pup > 4) {
    					/* 64 bit - 8 pups */
    					valid_pup = 0xFF;
    				} else if (cur_max_pup == 4) {
    					/* 32 bit - 4 pups */
    					valid_pup = 0xF;
    				} else {
    					/* 16 bit - 2 pups */
    					valid_pup = 0x3;
    				}
    
    				/* ECC Support - Switch ECC Mux on ecc=1 */
    				reg = reg_read(REG_DRAM_TRAINING_2_ADDR) &
    					~(1 << REG_DRAM_TRAINING_2_ECC_MUX_OFFS);
    				reg |= (dram_info->ecc_ena * ecc <<
    					REG_DRAM_TRAINING_2_ECC_MUX_OFFS);
    				reg_write(REG_DRAM_TRAINING_2_ADDR, reg);
    
    				if (ecc)
    					DEBUG_PBS_S("DDR3 - PBS Tx - ECC Mux Enabled\n");
    				else
    					DEBUG_PBS_S("DDR3 - PBS Tx - ECC Mux Disabled\n");
    
    				/* Init iteration values */
    				/* Clear the locked DQs */
    				for (pup = 0; pup < cur_max_pup; pup++) {
    					for (dq = 0; dq < DQ_NUM; dq++) {
    						pbs_locked_dq[
    							pup + ecc *
    							(max_pup - 1)][dq] =
    							0;
    					}
    				}
    
    				pbs_rep_time = 0;
    				cur_pup = valid_pup;
    				start_over = 0;
    
    				/*
    				 * Run loop On current Pattern and current
    				 * pattern iteration (just to cover the false
    				 * fail problem)
    				 */
    				do {
    					DEBUG_PBS_S("DDR3 - PBS Tx - Pbs Rep Loop is ");
    					DEBUG_PBS_D(pbs_rep_time, 1);
    					DEBUG_PBS_S(", for Retry No.");
    					DEBUG_PBS_D(pbs_retry, 1);
    					DEBUG_PBS_S("\n");
    
    					/* Set all PBS values to MIN (0) */
    					DEBUG_PBS_S("DDR3 - PBS Tx - Set all PBS values to MIN\n");
    
    					for (dq = 0; dq < DQ_NUM; dq++) {
    						ddr3_write_pup_reg(
    							PUP_PBS_TX +
    							pbs_dq_mapping[pup *
    								(1 - ecc) +
    								ecc * ECC_PUP]
    							[dq], CS0, (1 - ecc) *
    							PUP_BC + ecc * ECC_PUP, 0,
    							0);
    					}
    
    					/*
    					 * Shift DQ ADLL right, One step before
    					 * fail
    					 */
    					DEBUG_PBS_S("DDR3 - PBS Tx - ADLL shift right one phase before fail\n");
    
    					if (MV_OK != ddr3_tx_shift_dqs_adll_step_before_fail
    					    (dram_info, cur_pup, pattern_idx,
    					     ecc))
    						return MV_DDR3_TRAINING_ERR_PBS_ADLL_SHR_1PHASE;
    
    					/* PBS For each bit */
    					DEBUG_PBS_S("DDR3 - PBS Tx - perform PBS for each bit\n");
    
    					/*
    					 * In this stage - start_over = 0
    					 */
    					if (MV_OK != ddr3_pbs_per_bit(
    						    dram_info, &start_over, 1,
    						    &cur_pup, pattern_idx, ecc))
    						return MV_DDR3_TRAINING_ERR_PBS_TX_PER_BIT;
    
    				} while ((start_over == 1) &&
    					 (++pbs_rep_time < COUNT_PBS_STARTOVER));
    
    				if (pbs_rep_time == COUNT_PBS_STARTOVER &&
    				    start_over == 1) {
    					DEBUG_PBS_S("DDR3 - PBS Tx - FAIL - Adll reach max value\n");
    					return MV_DDR3_TRAINING_ERR_PBS_TX_MAX_VAL;
    				}
    
    				DEBUG_PBS_FULL_C("DDR3 - PBS TX - values for iteration - ",
    						 pbs_retry, 1);
    				for (pup = 0; pup < cur_max_pup; pup++) {
    					/*
    					 * To minimize delay elements, inc
    					 * from pbs value the min pbs val
    					 */
    					DEBUG_PBS_S("DDR3 - PBS - PUP");
    					DEBUG_PBS_D((pup + (ecc * ECC_PUP)), 1);
    					DEBUG_PBS_S(": ");
    
    					for (dq = 0; dq < DQ_NUM; dq++) {
    						/* Set skew value for all dq */
    						/*
    						 * Bit# Deskew <- Bit# Deskew -
    						 * last / first  failing bit
    						 * Deskew For all bits (per PUP)
    						 * (minimize delay elements)
    						 */
    						DEBUG_PBS_S("DQ");
    						DEBUG_PBS_D(dq, 1);
    						DEBUG_PBS_S("-");
    						DEBUG_PBS_D(skew_array
    							    [((pup) * DQ_NUM) +
    							     dq], 2);
    						DEBUG_PBS_S(", ");
    					}
    					DEBUG_PBS_S("\n");
    				}
    
    				/*
    				 * Collect the results we got on this trial
    				 * of PBS
    				 */
    				for (pup = 0; pup < cur_max_pup; pup++) {
    					for (dq = 0; dq < DQ_NUM; dq++) {
    						skew_sum_array[pup + (ecc * (max_pup - 1))]
    							[dq] += skew_array
    							[((pup) * DQ_NUM) + dq];
    					}
    				}
    
    				/* ECC Support - Disable ECC MUX */
    				reg = reg_read(REG_DRAM_TRAINING_2_ADDR) &
    					~(1 << REG_DRAM_TRAINING_2_ECC_MUX_OFFS);
    				reg_write(REG_DRAM_TRAINING_2_ADDR, reg);
    			}
    		}
    
    		DEBUG_PBS_C("DDR3 - PBS TX - values for current pattern - ",
    			    pattern_idx, 1);
    		for (pup = 0; pup < max_pup; pup++) {
    			/*
    			 * To minimize delay elements, inc from pbs value the
    			 * min pbs val
    			 */
    			DEBUG_PBS_S("DDR3 - PBS - PUP");
    			DEBUG_PBS_D(pup, 1);
    			DEBUG_PBS_S(": ");
    
    			for (dq = 0; dq < DQ_NUM; dq++) {
    				/* set skew value for all dq */
    				/* Bit# Deskew <- Bit# Deskew - last / first  failing bit Deskew For all bits (per PUP) (minimize delay elements) */
    				DEBUG_PBS_S("DQ");
    				DEBUG_PBS_D(dq, 1);
    				DEBUG_PBS_S("-");
    				DEBUG_PBS_D(skew_sum_array[pup][dq] /
    					    COUNT_PBS_REPEAT, 2);
    				DEBUG_PBS_S(", ");
    			}
    			DEBUG_PBS_S("\n");
    		}
    
    		/*
    		 * Calculate the average skew for current pattern for each
    		 * pup and each bit
    		 */
    		DEBUG_PBS_C("DDR3 - PBS TX - Average for pattern - ",
    			    pattern_idx, 1);
    
    		for (pup = 0; pup < max_pup; pup++) {
    			/*
    			 * FOR ECC only :: found min and max value for current
    			 * pattern skew array
    			 */
    			/* Loop for all dqs */
    			for (dq = 0; dq < DQ_NUM; dq++) {
    				pattern_skew_array[pup][dq] +=
    					(skew_sum_array[pup][dq] /
    					 COUNT_PBS_REPEAT);
    			}
    		}
    	}
    
    	/* Calculate the average skew */
    	for (pup = 0; pup < max_pup; pup++) {
    		for (dq = 0; dq < DQ_NUM; dq++)
    			skew_array[((pup) * DQ_NUM) + dq] =
    				pattern_skew_array[pup][dq] / COUNT_PBS_PATTERN;
    	}
    
    	DEBUG_PBS_S("DDR3 - PBS TX - Average for all patterns:\n");
    	for (pup = 0; pup < max_pup; pup++) {
    		/*
    		 * To minimize delay elements, inc from pbs value the min
    		 * pbs val
    		 */
    		DEBUG_PBS_S("DDR3 - PBS - PUP");
    		DEBUG_PBS_D(pup, 1);
    		DEBUG_PBS_S(": ");
    
    		for (dq = 0; dq < DQ_NUM; dq++) {
    			/* Set skew value for all dq */
    			/*
    			 * Bit# Deskew <- Bit# Deskew - last / first
    			 * failing bit Deskew For all bits (per PUP)
    			 * (minimize delay elements)
    			 */
    			DEBUG_PBS_S("DQ");
    			DEBUG_PBS_D(dq, 1);
    			DEBUG_PBS_S("-");
    			DEBUG_PBS_D(skew_array[(pup * DQ_NUM) + dq], 2);
    			DEBUG_PBS_S(", ");
    		}
    		DEBUG_PBS_S("\n");
    	}
    
    	/* Return ADLL to default value */
    	for (pup = 0; pup < max_pup; pup++) {
    		if (pup == (max_pup - 1) && dram_info->ecc_ena)
    			pup = ECC_PUP;
    		ddr3_pbs_write_pup_dqs_reg(CS0, pup, INIT_WL_DELAY);
    	}
    
    	/* Set averaged PBS results */
    	ddr3_set_pbs_results(dram_info, 1);
    
    	/* Disable SW override - Must be in a different stage */
    	/* [0]=0 - Enable SW override  */
    	reg = reg_read(REG_DRAM_TRAINING_2_ADDR);
    	reg &= ~(1 << REG_DRAM_TRAINING_2_SW_OVRD_OFFS);
    	/* 0x15B8 - Training SW 2 Register */
    	reg_write(REG_DRAM_TRAINING_2_ADDR, reg);
    
    	reg = reg_read(REG_DRAM_TRAINING_1_ADDR) |
    		(1 << REG_DRAM_TRAINING_1_TRNBPOINT_OFFS);
    	reg_write(REG_DRAM_TRAINING_1_ADDR, reg);
    
    	DEBUG_PBS_S("DDR3 - PBS Tx - PBS TX ended successfuly\n");
    
    	return MV_OK;
    }
    
    /*
     * Name:     ddr3_tx_shift_dqs_adll_step_before_fail
     * Desc:     Execute the Tx shift DQ phase.
     * Args:     dram_info            ddr3 training information struct
     *           cur_pup              bit array of the function active pups.
     *           pbs_pattern_idx      Index of PBS pattern
     * Notes:
     * Returns:  MV_OK if success, other error code if fail.
     */
    static int ddr3_tx_shift_dqs_adll_step_before_fail(MV_DRAM_INFO *dram_info,
    						   u32 cur_pup,
    						   u32 pbs_pattern_idx, u32 ecc)
    {
    	u32 unlock_pup;		/* bit array of unlock pups  */
    	u32 new_lockup_pup;	/* bit array of compare failed pups */
    	u32 adll_val = 4;	/* INIT_WL_DELAY */
    	u32 cur_max_pup, pup;
    	u32 dqs_dly_set[MAX_PUP_NUM] = { 0 };
    	u32 *pattern_ptr;
    
    	/* Choose pattern */
    	switch (dram_info->ddr_width) {
    #if defined(MV88F672X)
    	case 16:
    		pattern_ptr = (u32 *)&pbs_pattern[pbs_pattern_idx];
    		break;
    #endif
    	case 32:
    		pattern_ptr = (u32 *)&pbs_pattern_32b[pbs_pattern_idx];
    		break;
    #if defined(MV88F78X60)
    	case 64:
    		pattern_ptr = (u32 *)&pbs_pattern_64b[pbs_pattern_idx];
    		break;
    #endif
    	default:
    		return MV_FAIL;
    	}
    
    	/* Set current pup number */
    	if (cur_pup == 0x1)	/* Ecc mode */
    		cur_max_pup = 1;
    	else
    		cur_max_pup = dram_info->num_of_std_pups;
    
    	unlock_pup = cur_pup;	/* '1' for each unlocked pup */
    
    	/* Loop on all ADLL Vaules */
    	do {
    		/* Loop until found first fail */
    		adll_val++;
    
    		/*
    		 * Increment (Move to right - ADLL) DQ TX delay
    		 * (broadcast to all Data PUPs)
    		 */
    		for (pup = 0; pup < cur_max_pup; pup++)
    			ddr3_pbs_write_pup_dqs_reg(CS0,
    						   pup * (1 - ecc) +
    						   ECC_PUP * ecc, adll_val);
    
    		/*
    		 * Write and Read, compare results (read was already verified)
    		 */
    		/* 0 - all locked */
    		new_lockup_pup = 0;
    
    		if (MV_OK != ddr3_sdram_compare(dram_info, unlock_pup,
    						&new_lockup_pup,
    						pattern_ptr, LEN_PBS_PATTERN,
    						SDRAM_PBS_TX_OFFS, 1, 0,
    						NULL,
    						0))
    			return MV_FAIL;
    
    		unlock_pup &= ~new_lockup_pup;
    
    		DEBUG_PBS_FULL_S("Shift DQS by 2 steps for PUPs: ");
    		DEBUG_PBS_FULL_D(unlock_pup, 2);
    		DEBUG_PBS_FULL_C(", Set ADLL value = ", adll_val, 2);
    
    		/* If any PUP failed there is '1' to mark the PUP */
    		if (new_lockup_pup != 0) {
    			/*
    			 * Decrement (Move Back to Left two steps - ADLL)
    			 * DQ TX delay for current failed pups and save
    			 */
    			for (pup = 0; pup < cur_max_pup; pup++) {
    				if (((new_lockup_pup >> pup) & 0x1) &&
    				    dqs_dly_set[pup] == 0)
    					dqs_dly_set[pup] = adll_val - 1;
    			}
    		}
    	} while ((unlock_pup != 0) && (adll_val != ADLL_MAX));
    
    	if (unlock_pup != 0) {
    		DEBUG_PBS_FULL_S("DDR3 - PBS Tx - Shift DQ - Adll value reached maximum\n");
    
    		for (pup = 0; pup < cur_max_pup; pup++) {
    			if (((unlock_pup >> pup) & 0x1) &&
    			    dqs_dly_set[pup] == 0)
    				dqs_dly_set[pup] = adll_val - 1;
    		}
    	}
    
    	DEBUG_PBS_FULL_C("PBS TX one step before fail last pups locked Adll ",
    			 adll_val - 2, 2);
    
    	/* Set the PUP DQS DLY Values */
    	for (pup = 0; pup < cur_max_pup; pup++)
    		ddr3_pbs_write_pup_dqs_reg(CS0, pup * (1 - ecc) + ECC_PUP * ecc,
    					   dqs_dly_set[pup]);
    
    	/* Found one phase before fail */
    	return MV_OK;
    }
    
    /*
     * Name:     ddr3_pbs_rx
     * Desc:     Execute the PBS RX phase.
     * Args:     dram_info   ddr3 training information struct
     * Notes:
     * Returns:  MV_OK if success, other error code if fail.
     */
    int ddr3_pbs_rx(MV_DRAM_INFO *dram_info)
    {
    	/*
    	 * Array to hold the total sum of skew from all iterations
    	 * (for average purpose)
    	 */
    	u32 skew_sum_array[MAX_PUP_NUM][DQ_NUM] = { {0} };
    
    	/*
    	 * Array to hold the total average skew from both patterns
    	 * (for average purpose)
    	 */
    	u32 pattern_skew_array[MAX_PUP_NUM][DQ_NUM] = { {0} };
    
    	u32 pbs_rep_time = 0;	/* counts number of loop in case of fail */
    	/* bit array for unlock pups - used to repeat on the RX operation */
    	u32 cur_pup;
    	u32 max_pup;
    	u32 pbs_retry;
    	u32 pup, dq, pups, cur_max_pup, valid_pup, reg;
    	u32 pattern_idx;
    	u32 ecc;
    	/* indicates whether we need to start the loop again */
    	int start_over;
    	int status;
    
    	DEBUG_PBS_S("DDR3 - PBS RX - Starting PBS RX procedure\n");
    
    	pups = dram_info->num_of_total_pups;
    	max_pup = dram_info->num_of_total_pups;
    
    	/* Enable SW override */
    	reg = reg_read(REG_DRAM_TRAINING_2_ADDR) |
    		(1 << REG_DRAM_TRAINING_2_SW_OVRD_OFFS);
    	/* [0] = 1 - Enable SW override  */
    	/* 0x15B8 - Training SW 2 Register */
    	reg_write(REG_DRAM_TRAINING_2_ADDR, reg);
    	DEBUG_PBS_FULL_S("DDR3 - PBS RX - SW Override Enabled\n");
    
    	reg = 1 << REG_DRAM_TRAINING_AUTO_OFFS;
    	reg_write(REG_DRAM_TRAINING_ADDR, reg);	/* 0x15B0 - Training Register */
    
    	/* Running twice for 2 different patterns. each patterns - 3 times */
    	for (pattern_idx = 0; pattern_idx < COUNT_PBS_PATTERN; pattern_idx++) {
    		DEBUG_PBS_FULL_C("DDR3 - PBS RX - Working with pattern - ",
    				 pattern_idx, 1);
    
    		/* Reset sum array */
    		for (pup = 0; pup < pups; pup++) {
    			for (dq = 0; dq < DQ_NUM; dq++)
    				skew_sum_array[pup][dq] = 0;
    		}
    
    		/*
    		 * Perform PBS several of times (3 for each pattern).
    		 * At the end, we'll use the average
    		 */
    		/* If there is ECC, do each PBS again with mux change */
    		for (pbs_retry = 0; pbs_retry < COUNT_PBS_REPEAT; pbs_retry++) {
    			for (ecc = 0; ecc < (dram_info->ecc_ena + 1); ecc++) {
    				/*
    				 * This parameter stores the current PUP
    				 * num - ecc mode dependent - 4-8 / 1 pups
    				 */
    				cur_max_pup = (1 - ecc) *
    					dram_info->num_of_std_pups + ecc;
    
    				if (ecc) {
    					/* Only 1 pup in this case */
    					valid_pup = 0x1;
    				} else if (cur_max_pup > 4) {
    					/* 64 bit - 8 pups */
    					valid_pup = 0xFF;
    				} else if (cur_max_pup == 4) {
    					/* 32 bit - 4 pups */
    					valid_pup = 0xF;
    				} else {
    					/* 16 bit - 2 pups */
    					valid_pup = 0x3;
    				}
    
    				/* ECC Support - Switch ECC Mux on ecc=1 */
    				reg = reg_read(REG_DRAM_TRAINING_2_ADDR) &
    					~(1 << REG_DRAM_TRAINING_2_ECC_MUX_OFFS);
    				reg |= (dram_info->ecc_ena * ecc <<
    					REG_DRAM_TRAINING_2_ECC_MUX_OFFS);
    				reg_write(REG_DRAM_TRAINING_2_ADDR, reg);
    
    				if (ecc)
    					DEBUG_PBS_FULL_S("DDR3 - PBS Rx - ECC Mux Enabled\n");
    				else
    					DEBUG_PBS_FULL_S("DDR3 - PBS Rx - ECC Mux Disabled\n");
    
    				/* Init iteration values */
    				/* Clear the locked DQs */
    				for (pup = 0; pup < cur_max_pup; pup++) {
    					for (dq = 0; dq < DQ_NUM; dq++) {
    						pbs_locked_dq[
    							pup + ecc * (max_pup - 1)][dq] =
    							0;
    					}
    				}
    
    				pbs_rep_time = 0;
    				cur_pup = valid_pup;
    				start_over = 0;
    
    				/*
    				 * Run loop On current Pattern and current
    				 * pattern iteration (just to cover the false
    				 * fail problem
    				 */
    				do {
    					DEBUG_PBS_FULL_S("DDR3 - PBS Rx - Pbs Rep Loop is ");
    					DEBUG_PBS_FULL_D(pbs_rep_time, 1);
    					DEBUG_PBS_FULL_S(", for Retry No.");
    					DEBUG_PBS_FULL_D(pbs_retry, 1);
    					DEBUG_PBS_FULL_S("\n");
    
    					/* Set all PBS values to MAX (31) */
    					for (pup = 0; pup < cur_max_pup; pup++) {
    						for (dq = 0; dq < DQ_NUM; dq++)
    							ddr3_write_pup_reg(
    								PUP_PBS_RX +
    								pbs_dq_mapping[
    								pup * (1 - ecc)
    								+ ecc * ECC_PUP]
    								[dq], CS0,
    								pup + ecc * ECC_PUP,
    								0, MAX_PBS);
    					}
    
    					/* Set all DQS PBS values to MIN (0) */
    					for (pup = 0; pup < cur_max_pup; pup++) {
    						ddr3_write_pup_reg(PUP_PBS_RX +
    								   DQ_NUM, CS0,
    								   pup +
    								   ecc *
    								   ECC_PUP, 0,
    								   0);
    					}
    
    					/* Shift DQS, To first Fail */
    					DEBUG_PBS_FULL_S("DDR3 - PBS Rx - Shift RX DQS to first fail\n");
    
    					status = ddr3_rx_shift_dqs_to_first_fail
    						(dram_info, cur_pup,
    						 pattern_idx, ecc);
    					if (MV_OK != status) {
    						DEBUG_PBS_S("DDR3 - PBS Rx - ddr3_rx_shift_dqs_to_first_fail failed.\n");
    						DEBUG_PBS_D(status, 8);
    						DEBUG_PBS_S("\nDDR3 - PBS Rx - SKIP.\n");
    
    						/* Reset read FIFO */
    						reg = reg_read(REG_DRAM_TRAINING_ADDR);
    						/* Start Auto Read Leveling procedure */
    						reg |= (1 << REG_DRAM_TRAINING_RL_OFFS);
    						/* 0x15B0 - Training Register */
    						reg_write(REG_DRAM_TRAINING_ADDR, reg);
    
    						reg = reg_read(REG_DRAM_TRAINING_2_ADDR);
    						reg |= ((1 << REG_DRAM_TRAINING_2_FIFO_RST_OFFS)
    							+ (1 << REG_DRAM_TRAINING_2_SW_OVRD_OFFS));
    						/* [0] = 1 - Enable SW override, [4] = 1 - FIFO reset  */
    						/* 0x15B8 - Training SW 2 Register */
    						reg_write(REG_DRAM_TRAINING_2_ADDR, reg);
    
    						do {
    							reg = (reg_read(REG_DRAM_TRAINING_2_ADDR))
    								& (1 <<	REG_DRAM_TRAINING_2_FIFO_RST_OFFS);
    						} while (reg);	/* Wait for '0' */
    
    						reg = reg_read(REG_DRAM_TRAINING_ADDR);
    						/* Clear Auto Read Leveling procedure */
    						reg &= ~(1 << REG_DRAM_TRAINING_RL_OFFS);
    						/* 0x15B0 - Training Register */
    						reg_write(REG_DRAM_TRAINING_ADDR, reg);
    
    						/* Set ADLL to 15 */
    						for (pup = 0; pup < max_pup;
    						     pup++) {
    							ddr3_write_pup_reg
    							    (PUP_DQS_RD, CS0,
    							     pup +
    							     (ecc * ECC_PUP), 0,
    							     15);
    						}
    
    						/* Set all PBS values to MIN (0) */
    						for (pup = 0; pup < cur_max_pup;
    						     pup++) {
    							for (dq = 0;
    							     dq < DQ_NUM; dq++)
    								ddr3_write_pup_reg
    								    (PUP_PBS_RX +
    								     pbs_dq_mapping
    								     [pup * (1 - ecc) +
    								      ecc * ECC_PUP]
    								     [dq], CS0,
    								     pup + ecc * ECC_PUP,
    								     0, MIN_PBS);
    						}
    
    						return MV_OK;
    					}
    
    					/* PBS For each bit */
    					DEBUG_PBS_FULL_S("DDR3 - PBS Rx - perform PBS for each bit\n");
    					/* in this stage - start_over = 0; */
    					if (MV_OK != ddr3_pbs_per_bit(
    						    dram_info, &start_over,
    						    0, &cur_pup,
    						    pattern_idx, ecc)) {
    						DEBUG_PBS_S("DDR3 - PBS Rx - ddr3_pbs_per_bit failed.");
    						return MV_DDR3_TRAINING_ERR_PBS_RX_PER_BIT;
    					}
    
    				} while ((start_over == 1) &&
    					 (++pbs_rep_time < COUNT_PBS_STARTOVER));
    
    				if (pbs_rep_time == COUNT_PBS_STARTOVER &&
    				    start_over == 1) {
    					DEBUG_PBS_FULL_S("DDR3 - PBS Rx - FAIL - Algorithm failed doing RX PBS\n");
    					return MV_DDR3_TRAINING_ERR_PBS_RX_MAX_VAL;
    				}
    
    				/* Return DQS ADLL to default value - 15 */
    				/* Set all DQS PBS values to MIN (0) */
    				for (pup = 0; pup < cur_max_pup; pup++)
    					ddr3_write_pup_reg(PUP_DQS_RD, CS0,
    							   pup + ecc * ECC_PUP,
    							   0, INIT_RL_DELAY);
    
    				DEBUG_PBS_FULL_C("DDR3 - PBS RX - values for iteration - ",
    						 pbs_retry, 1);
    				for (pup = 0; pup < cur_max_pup; pup++) {
    					/*
    					 * To minimize delay elements, inc from
    					 * pbs value the min pbs val
    					 */
    					DEBUG_PBS_FULL_S("DDR3 - PBS - PUP");
    					DEBUG_PBS_FULL_D((pup +
    							  (ecc * ECC_PUP)), 1);
    					DEBUG_PBS_FULL_S(": ");
    
    					for (dq = 0; dq < DQ_NUM; dq++) {
    						/* Set skew value for all dq */
    						/*
    						 * Bit# Deskew <- Bit# Deskew -
    						 * last / first  failing bit
    						 * Deskew For all bits (per PUP)
    						 * (minimize delay elements)
    						 */
    						DEBUG_PBS_FULL_S("DQ");
    						DEBUG_PBS_FULL_D(dq, 1);
    						DEBUG_PBS_FULL_S("-");
    						DEBUG_PBS_FULL_D(skew_array
    								 [((pup) *
    								   DQ_NUM) +
    								  dq], 2);
    						DEBUG_PBS_FULL_S(", ");
    					}
    					DEBUG_PBS_FULL_S("\n");
    				}
    
    				/*
    				 * Collect the results we got on this trial
    				 * of PBS
    				 */
    				for (pup = 0; pup < cur_max_pup; pup++) {
    					for (dq = 0; dq < DQ_NUM; dq++) {
    						skew_sum_array
    							[pup + (ecc * (max_pup - 1))]
    							[dq] +=
    							skew_array[((pup) * DQ_NUM) + dq];
    					}
    				}
    
    				/* ECC Support - Disable ECC MUX */
    				reg = reg_read(REG_DRAM_TRAINING_2_ADDR) &
    					~(1 << REG_DRAM_TRAINING_2_ECC_MUX_OFFS);
    				reg_write(REG_DRAM_TRAINING_2_ADDR, reg);
    			}
    		}
    
    		/*
    		 * Calculate the average skew for current pattern for each
    		 * pup and each bit
    		 */
    		DEBUG_PBS_FULL_C("DDR3 - PBS RX - Average for pattern - ",
    				 pattern_idx, 1);
    		for (pup = 0; pup < max_pup; pup++) {
    			/*
    			 * FOR ECC only :: found min and max value for
    			 * current pattern skew array
    			 */
    			/* Loop for all dqs */
    			for (dq = 0; dq < DQ_NUM; dq++) {
    				pattern_skew_array[pup][dq] +=
    					(skew_sum_array[pup][dq] /
    					 COUNT_PBS_REPEAT);
    			}
    		}
    
    		DEBUG_PBS_C("DDR3 - PBS RX - values for current pattern - ",
    			    pattern_idx, 1);
    		for (pup = 0; pup < max_pup; pup++) {
    			/*
    			 * To minimize delay elements, inc from pbs value the
    			 * min pbs val
    			 */
    			DEBUG_PBS_S("DDR3 - PBS RX - PUP");
    			DEBUG_PBS_D(pup, 1);
    			DEBUG_PBS_S(": ");
    
    			for (dq = 0; dq < DQ_NUM; dq++) {
    				/* Set skew value for all dq */
    				/*
    				 * Bit# Deskew <- Bit# Deskew - last / first
    				 * failing bit Deskew For all bits (per PUP)
    				 * (minimize delay elements)
    				 */
    				DEBUG_PBS_S("DQ");
    				DEBUG_PBS_D(dq, 1);
    				DEBUG_PBS_S("-");
    				DEBUG_PBS_D(skew_sum_array[pup][dq] /
    					    COUNT_PBS_REPEAT, 2);
    				DEBUG_PBS_S(", ");
    			}
    			DEBUG_PBS_S("\n");
    		}
    	}
    
    	/* Calculate the average skew */
    	for (pup = 0; pup < max_pup; pup++) {
    		for (dq = 0; dq < DQ_NUM; dq++)
    			skew_array[((pup) * DQ_NUM) + dq] =
    				pattern_skew_array[pup][dq] / COUNT_PBS_PATTERN;
    	}
    
    	DEBUG_PBS_S("DDR3 - PBS RX - Average for all patterns:\n");
    	for (pup = 0; pup < max_pup; pup++) {
    		/*
    		 * To minimize delay elements, inc from pbs value the
    		 * min pbs val
    		 */
    		DEBUG_PBS_S("DDR3 - PBS - PUP");
    		DEBUG_PBS_D(pup, 1);
    		DEBUG_PBS_S(": ");
    
    		for (dq = 0; dq < DQ_NUM; dq++) {
    			/* Set skew value for all dq */
    			/*
    			 * Bit# Deskew <- Bit# Deskew - last / first
    			 * failing bit Deskew For all bits (per PUP)
    			 * (minimize delay elements)
    			 */
    			DEBUG_PBS_S("DQ");
    			DEBUG_PBS_D(dq, 1);
    			DEBUG_PBS_S("-");
    			DEBUG_PBS_D(skew_array[(pup * DQ_NUM) + dq], 2);
    			DEBUG_PBS_S(", ");
    		}
    		DEBUG_PBS_S("\n");
    	}
    
    	/* Return ADLL to default value */
    	ddr3_write_pup_reg(PUP_DQS_RD, CS0, PUP_BC, 0, INIT_RL_DELAY);
    
    	/* Set averaged PBS results */
    	ddr3_set_pbs_results(dram_info, 0);
    
    	/* Disable SW override - Must be in a different stage */
    	/* [0]=0 - Enable SW override  */
    	reg = reg_read(REG_DRAM_TRAINING_2_ADDR);
    	reg &= ~(1 << REG_DRAM_TRAINING_2_SW_OVRD_OFFS);
    	/* 0x15B8 - Training SW 2 Register */
    	reg_write(REG_DRAM_TRAINING_2_ADDR, reg);
    
    	reg = reg_read(REG_DRAM_TRAINING_1_ADDR) |
    		(1 << REG_DRAM_TRAINING_1_TRNBPOINT_OFFS);
    	reg_write(REG_DRAM_TRAINING_1_ADDR, reg);
    
    	DEBUG_PBS_FULL_S("DDR3 - PBS RX - ended successfuly\n");
    
    	return MV_OK;
    }
    
    /*
     * Name:     ddr3_rx_shift_dqs_to_first_fail
     * Desc:     Execute the Rx shift DQ phase.
     * Args:     dram_info           ddr3 training information struct
     *           cur_pup             bit array of the function active pups.
     *           pbs_pattern_idx     Index of PBS pattern
     * Notes:
     * Returns:  MV_OK if success, other error code if fail.
     */
    static int ddr3_rx_shift_dqs_to_first_fail(MV_DRAM_INFO *dram_info, u32 cur_pup,
    					   u32 pbs_pattern_idx, u32 ecc)
    {
    	u32 unlock_pup;		/* bit array of unlock pups  */
    	u32 new_lockup_pup;	/* bit array of compare failed pups */
    	u32 adll_val = MAX_DELAY;
    	u32 dqs_deskew_val = 0;	/* current value of DQS PBS deskew */
    	u32 cur_max_pup, pup, pass_pup;
    	u32 *pattern_ptr;
    
    	/* Choose pattern */
    	switch (dram_info->ddr_width) {
    #if defined(MV88F672X)
    	case 16:
    		pattern_ptr = (u32 *)&pbs_pattern[pbs_pattern_idx];
    		break;
    #endif
    	case 32:
    		pattern_ptr = (u32 *)&pbs_pattern_32b[pbs_pattern_idx];
    		break;
    #if defined(MV88F78X60)
    	case 64:
    		pattern_ptr = (u32 *)&pbs_pattern_64b[pbs_pattern_idx];
    		break;
    #endif
    	default:
    		return MV_FAIL;
    	}
    
    	/* Set current pup number */
    	if (cur_pup == 0x1)	/* Ecc mode */
    		cur_max_pup = 1;
    	else
    		cur_max_pup = dram_info->num_of_std_pups;
    
    	unlock_pup = cur_pup;	/* '1' for each unlocked pup */
    
    	DEBUG_PBS_FULL_S("DDR3 - PBS RX - Shift DQS - Starting...\n");
    
    	/* Set DQS ADLL to MAX */
    	DEBUG_PBS_FULL_S("DDR3 - PBS RX - Shift DQS - Set DQS ADLL to Max for all PUPs\n");
    	for (pup = 0; pup < cur_max_pup; pup++)
    		ddr3_write_pup_reg(PUP_DQS_RD, CS0, pup + ecc * ECC_PUP, 0,
    				   MAX_DELAY);
    
    	/* Loop on all ADLL Vaules */
    	do {
    		/* Loop until found fail for all pups */
    		new_lockup_pup = 0;
    		if (MV_OK != ddr3_sdram_compare(dram_info, unlock_pup,
    						&new_lockup_pup,
    						pattern_ptr, LEN_PBS_PATTERN,
    						SDRAM_PBS_I_OFFS +
    						pbs_pattern_idx * SDRAM_PBS_NEXT_OFFS,
    						0, 0, NULL, 0)) {
    			DEBUG_PBS_S("DDR3 - PBS Rx - Shift DQS - MV_DDR3_TRAINING_ERR_PBS_SHIFT_QDS_SRAM_CMP(ddr3_sdram_compare)\n");
    			return MV_DDR3_TRAINING_ERR_PBS_SHIFT_QDS_SRAM_CMP;
    		}
    
    		if ((new_lockup_pup != 0) && (dqs_deskew_val <= 1)) {
    			/* Fail on start with first deskew value */
    			/* Decrement DQS ADLL */
    			--adll_val;
    			if (adll_val == ADLL_MIN) {
    				DEBUG_PBS_S("DDR3 - PBS Rx - Shift DQS - fail on start with first deskew value\n");
    				return MV_DDR3_TRAINING_ERR_PBS_SHIFT_QDS_SRAM_CMP;
    			}
    			ddr3_write_pup_reg(PUP_DQS_RD, CS0, pup + ecc * ECC_PUP,
    					   0, adll_val);
    			continue;
    		}
    
    		/* Update all new locked pups */
    		unlock_pup &= ~new_lockup_pup;
    
    		if ((unlock_pup == 0) || (dqs_deskew_val == MAX_PBS)) {
    			if (dqs_deskew_val == MAX_PBS) {
    				/*
    				 * Reach max value of dqs deskew or get fail
    				 * for all pups
    				 */
    				DEBUG_PBS_FULL_S("DDR3 - PBS RX - Shift DQS - DQS deskew reached maximum value\n");
    			}
    			break;