Skip to content
Snippets Groups Projects
  1. May 18, 2016
  2. May 17, 2016
  3. May 16, 2016
  4. May 15, 2016
  5. May 13, 2016
  6. May 12, 2016
  7. May 10, 2016
  8. May 07, 2016
  9. May 06, 2016
    • Peng Fan's avatar
      usb: gadget: dfu: discard dead code · 12ff19db
      Peng Fan authored
      
      Reported by Coverity:
      Logically dead code (DEADCODE)
      dead_error_line: Execution cannot reach this statement:
      (f_dfu->strings + --i).s = ....
      
      If calloc failed, i is still 0 and no need to call free,
      so discard the dead code.
      
      Signed-off-by: default avatarPeng Fan <van.freenix@gmail.com>
      Cc: "Łukasz Majewski" <l.majewski@samsung.com>
      Cc: Marek Vasut <marex@denx.de>
      12ff19db
    • Peng Fan's avatar
      dfu: avoid memory leak · 5d8fae79
      Peng Fan authored
      
      When dfu_fill_entity fail, need to free dfu to avoid memory leak.
      
      Reported by Coverity:
      "
      Resource leak (RESOURCE_LEAK)
      leaked_storage: Variable dfu going out of scope leaks the storage
      it points to.
      "
      
      Signed-off-by: default avatarPeng Fan <van.freenix@gmail.com>
      Cc: "Łukasz Majewski" <l.majewski@samsung.com>
      Cc: Marek Vasut <marex@denx.de>
      5d8fae79
    • Stefan Roese's avatar
      usb: dwc2: Add delay to fix the USB detection problem on SoCFPGA · 2bf352f0
      Stefan Roese authored
      
      With patch c998da0d (usb: Change power-on / scanning timeout handling),
      the USB scanning is started earlier and with a smaller timeout. This
      resulted on SoCFPGA (using the DWC2 driver) in some USB sticks not
      getting detected any more. This patch now adds a 1 second delay (in
      the host mode only) to the DWC2 driver before the scanning is started.
      With this delay, now all problematic USB keys are detected successfully
      again. And there is no need any more to change the delay / timeout
      in the common USB code (usb_hub.c).
      
      Signed-off-by: default avatarStefan Roese <sr@denx.de>
      Cc: Chin Liang See <clsee@altera.com>
      Cc: Dinh Nguyen <dinguyen@opensource.altera.com>
      Cc: Hans de Goede <hdegoede@redhat.com>
      Cc: Stephen Warren <swarren@nvidia.com>
      Cc: Marek Vasut <marex@denx.de>
      2bf352f0
    • Marek Vasut's avatar
      usb: hub: Don't continue on get_port_status failure · d81db48d
      Marek Vasut authored
      
      The code shouldn't continue probing the port if get_port_status() failed.
      
      Signed-off-by: default avatarMarek Vasut <marex@denx.de>
      Cc: Chin Liang See <clsee@altera.com>
      Cc: Dinh Nguyen <dinguyen@opensource.altera.com>
      Cc: Hans de Goede <hdegoede@redhat.com>
      Cc: Stefan Roese <sr@denx.de>
      Cc: Stephen Warren <swarren@nvidia.com>
      d81db48d
    • Marek Vasut's avatar
      usb: Assure Get Descriptor request is in separate microframe · ef71290b
      Marek Vasut authored
      
      The Kingston DT Ultimate USB 3.0 stick is sensitive to this first
      Get Descriptor request and if the request is not in a separate
      microframe, the stick refuses to operate. Add slight delay, which
      is enough for one microframe to pass on any USB spec revision.
      
      Signed-off-by: default avatarMarek Vasut <marex@denx.de>
      Cc: Chin Liang See <clsee@altera.com>
      Cc: Dinh Nguyen <dinguyen@opensource.altera.com>
      Cc: Hans de Goede <hdegoede@redhat.com>
      Cc: Stefan Roese <sr@denx.de>
      Cc: Stephen Warren <swarren@nvidia.com>
      ef71290b
    • Marek Vasut's avatar
      usb: Wait after sending Set Configuration request · f647bf0b
      Marek Vasut authored
      
      Some devices, like the SanDisk Cruzer Pop need some time to process
      the Set Configuration request, so wait a little until they are ready.
      
      Signed-off-by: default avatarMarek Vasut <marex@denx.de>
      Cc: Chin Liang See <clsee@altera.com>
      Cc: Dinh Nguyen <dinguyen@opensource.altera.com>
      Cc: Hans de Goede <hdegoede@redhat.com>
      Cc: Stefan Roese <sr@denx.de>
      Cc: Stephen Warren <swarren@nvidia.com>
      f647bf0b
    • Anatolij Gustschin's avatar
      socfpga: fix broken build if CONFIG_ETH_DESIGNWARE disabled · 5289c5fa
      Anatolij Gustschin authored
      
      Building without ethernet driver doesn't work. Fix it.
      
      Signed-off-by: default avatarAnatolij Gustschin <agust@denx.de>
      Cc: Marek Vasut <marex@denx.de>
      5289c5fa
    • Marek Vasut's avatar
      mtd: cqspi: Simplify indirect read code · 5a824c49
      Marek Vasut authored
      
      The indirect read code is a pile of nastiness. This patch replaces
      the whole unmaintainable indirect read implementation with the one
      from upcoming Linux CQSPI driver, which went through multiple rounds
      of thorough review and testing. All the patch does is it plucks out
      duplicate ad-hoc code distributed across the driver and replaces it
      with more compact code doing exactly the same thing. There is no
      speed change of the read operation.
      
      Signed-off-by: default avatarMarek Vasut <marex@denx.de>
      Cc: Anatolij Gustschin <agust@denx.de>
      Cc: Chin Liang See <clsee@altera.com>
      Cc: Dinh Nguyen <dinguyen@opensource.altera.com>
      Cc: Jagan Teki <jteki@openedev.com>
      Cc: Pavel Machek <pavel@denx.de>
      Cc: Stefan Roese <sr@denx.de>
      Cc: Vignesh R <vigneshr@ti.com>
      5a824c49
    • Marek Vasut's avatar
      mtd: cqspi: Simplify indirect write code · 26da6353
      Marek Vasut authored
      
      The indirect write code is buggy pile of nastiness which fails horribly
      when the system runs fast enough to saturate the controller. The failure
      results in some pages (256B) not being written to the flash. This can be
      observed on systems which run with Dcache enabled and L2 cache enabled,
      like the Altera SoCFPGA.
      
      This patch replaces the whole unmaintainable indirect write implementation
      with the one from upcoming Linux CQSPI driver, which went through multiple
      rounds of thorough review and testing. While this makes the patch look
      terrifying and violates all best-practices of software development, all
      the patch does is it plucks out duplicate ad-hoc code distributed across
      the driver and replaces it with more compact code doing exactly the same
      thing.
      
      Signed-off-by: default avatarMarek Vasut <marex@denx.de>
      Cc: Anatolij Gustschin <agust@denx.de>
      Cc: Chin Liang See <clsee@altera.com>
      Cc: Dinh Nguyen <dinguyen@opensource.altera.com>
      Cc: Jagan Teki <jteki@openedev.com>
      Cc: Pavel Machek <pavel@denx.de>
      Cc: Stefan Roese <sr@denx.de>
      Cc: Vignesh R <vigneshr@ti.com>
      26da6353
    • Stefan Roese's avatar
      arm: socfpga: socrates: Add 'time' command · 8b1a0749
      Stefan Roese authored
      
      The time command is very helpful for performance and regressions tests.
      So lets enable it on SoCrates.
      
      Signed-off-by: default avatarStefan Roese <sr@denx.de>
      Cc: Marek Vasut <marex@denx.de>
      8b1a0749
    • Marek Vasut's avatar
      ARM: socfpga: Disable USB OC protection on SoCrates · 268da813
      Marek Vasut authored
      
      This is mandatory, otherwise the USB does not work.
      
      Signed-off-by: default avatarMarek Vasut <marex@denx.de>
      Cc: Stefan Roese <sr@denx.de>
      Cc: Dinh Nguyen <dinguyen@kernel.org>
      268da813
    • Marek Vasut's avatar
      usb: Don't init pointer to zero, but NULL · 2f1b4302
      Marek Vasut authored
      
      The pointer should always be inited to NULL, not zero (0). These are
      two different things and not necessarily equal.
      
      Signed-off-by: default avatarMarek Vasut <marex@denx.de>
      Cc: Chin Liang See <clsee@altera.com>
      Cc: Dinh Nguyen <dinguyen@opensource.altera.com>
      Cc: Hans de Goede <hdegoede@redhat.com>
      Cc: Stefan Roese <sr@denx.de>
      Cc: Stephen Warren <swarren@nvidia.com>
      2f1b4302
    • Stefan Agner's avatar
      usb: ehci-mx6: allow board_ehci_hcd_init to fail · 79d867c2
      Stefan Agner authored
      
      There could be runtime determined board specific reason why a EHCI
      initialization fails (e.g. ENODEV if a Port is not available). In
      this case, properly return the error code.
      While at it, that function (board_ehci_hcd_init) has actually two
      documentation blocks... Use the correct function name for the
      documentation block of board_usb_phy_mode.
      
      Signed-off-by: default avatarStefan Agner <stefan@agner.ch>
      79d867c2
    • Peng Fan's avatar
      imx6: cache: disable L2 before touching Auxiliary Control Register · ad7af5d7
      Peng Fan authored
      
      According PL310 TRM, Auxiliary Control Register
      "
      The register must be written to using a secure access, and it can be
      read using either a secure or a NS access. If you write to this register
      with a NS access, it results in a write response with a DECERR response,
      and the register is not updated. Writing to this register with the L2
      cache enabled, that is, bit[0] of L2 Control Register set to 1,
      results in a SLVERR.
      "
      
      So If L2 cache is already enabled by ROM, chaning value of ACR
      will cause SLVERR and uboot hang.
      
      Signed-off-by: default avatarPeng Fan <peng.fan@nxp.com>
      Cc: Stefano Babic <sbabic@denx.de>
      Cc: Fabio Estevam <fabio.estevam@nxp.com>
      ad7af5d7
    • Stephen Warren's avatar
      test/py: dfu: wait for USB device to go away at boot · daa69f5f
      Stephen Warren authored
      
      It can take a while for a host machine to notice that a USB device has
      disconnected, and process the change. At the end of the DFU test, we wait
      up to 10 seconds for this to happen. This change makes the test wait the
      same (up to) 10 seconds at the start of the test for any previously active
      USB device-mode session to be cleaned up. Such as session might have been
      used to download U-Boot into memory for example; this is certainly true
      on my Tegra test systems. This changes should solve the DFU test
      intermittency issues I've been seeing on some Tegra devices.
      
      Signed-off-by: default avatarStephen Warren <swarren@nvidia.com>
      daa69f5f
    • Russ Dill's avatar
      ARM: am33xx: Fix DDR initialization delays · b67d6b00
      Russ Dill authored
      
      The current delays in the DDR initialization routines for am33xx
      architectures are sometimes not running long enough leading to DDR
      init errors. On am437x, this shows up as an L3 NOC error after the
      kernel boots. This is due to the timer not being initialized
      properly, but instead still containing the timer init values from
      the boot ROM which cause timers to expire in 1/4th the time
      required.
      
      timer_init is typically not called until board_init_r, however on
      am33xx/am43xx udelay is required in sdram_init which is called
      from board_init_f, so a call to timer_init is required earlier.
      
      Note that this issue introduced in v2015.01 by:
      
      b352dde1 "am33xx: Drop timer_init call from s_init".
      
      Although this could instead fixed by reverting said commit, it
      would cause timer_init to be called twice in both SPL and non-SPL
      cases. This gives a little more fine grained control and also
      matches what is being done on omap-command and fsl-layerscape.
      
      Signed-off-by: default avatarRuss Dill <russ.dill@ti.com>
      b67d6b00
    • Stephen Warren's avatar
      ARM: fix ifdefs in ARMv8 lowlevel_init() · 11661193
      Stephen Warren authored
      
      Commit 724219a6 "ARM: always perform per-CPU GIC init" removed some
      ifdefs to unify the MULTIENTRY-vs-non-MULTIENTRY paths. However, the
      wrong endif was removed. This patch adds back that missing endif, and
      adds a new ifdef to match the endif the now-correctly-terminated block
      used to match against. Use "git show -U25 724219a6" to see enough
      context to make the original issue clear.
      
      In practical terms, this makes no difference to runtime behaviour. The
      code that was incorrectly compiled into the binary when ifndef MULTIENTRY
      is a no-op for other cases, since branch_if_master evaluates to a hard-
      coded jump. The only issues were:
      
      - A few extra instructions were added to the binary.
      - The comment on the endif at the very end of the function, indicating
      which ifdef it matched, were wrong.
      
      An alternative might be to simply fix the comment on that trailing ifdef,
      but that only addresses the second point above, not the first.
      
      Fixes: 724219a6 ("ARM: always perform per-CPU GIC init")
      Cc: Masahiro Yamada <yamada.masahiro@socionext.com>
      Signed-off-by: default avatarStephen Warren <swarren@nvidia.com>
      Reviewed-by: default avatarMasahiro Yamada <yamada.masahiro@socionext.com>
      11661193
    • Robert P. J. Day's avatar
      Fix various typos, scattered over the code. · 1cc0a9f4
      Robert P. J. Day authored
      Spelling corrections for (among other things):
      
      * environment
      * override
      * variable
      * ftd (should be "fdt", for flattened device tree)
      * embedded
      * FTDI
      * emulation
      * controller
      1cc0a9f4
    • Marek Vasut's avatar
      mmc: Fix error in RPMB code · b955e42b
      Marek Vasut authored
      
      Since we do not build any board with CONFIG_SUPPORT_EMMC_RPMB , this
      piece of code evaded conversion. Fix the following compiler error:
      
      cmd/mmc.c: In function 'do_mmcrpmb':
      cmd/mmc.c:316:32: error: 'struct blk_desc' has no member named 'part_num'
        original_part = mmc->block_dev.part_num;
                                      ^
      
      Signed-off-by: default avatarMarek Vasut <marex@denx.de>
      Cc: Pantelis Antoniou <panto@antoniou-consulting.com>
      Cc: Tom Rini <trini@konsulko.com>
      b955e42b
    • Ash Charles's avatar
      omap4: duovero: Disable EFI booting · 4bf11dc8
      Ash Charles authored
      
      The DuoVero board fails to compile with EFI enabled as the generated
      binaries are too large.  As this platform doesn't currently need EFI,
      disable this feature.
      
      Signed-off-by: default avatarAsh Charles <ashcharles@gmail.com>
      4bf11dc8
    • Ash Charles's avatar
      omap4: load files for legacy boot · ea948590
      Ash Charles authored
      
      Be sure to load the zImage and fdtfile prior to actually booting in
      case we are doing a legacy boot.
      
      Signed-off-by: default avatarAsh Charles <ashcharles@gmail.com>
      ea948590
  10. May 04, 2016
Loading