Skip to content
Snippets Groups Projects
Commit aa997d1d authored by Tom Rini's avatar Tom Rini
Browse files

drivers/gpio/pm8916_gpio.c: Make pid be uint32_t


If get_dev_addr fails it will return FDT_ADDR_T_NONE and:
>>>     "priv->pid == 4294967295U" is always false regardless of the values of its operands. This occurs as the logical operand of if.

Cc: Mateusz Kulikowski <mateusz.kulikowski@gmail.com>
Reported-by: Coverity (CID: 143913)
Signed-off-by: default avatarTom Rini <trini@konsulko.com>
parent 55ac54c4
No related branches found
No related tags found
No related merge requests found
......@@ -50,7 +50,7 @@ DECLARE_GLOBAL_DATA_PTR;
#define REG_EN_CTL_ENABLE (1 << 7)
struct pm8916_gpio_bank {
uint16_t pid; /* Peripheral ID on SPMI bus */
uint32_t pid; /* Peripheral ID on SPMI bus */
};
static int pm8916_gpio_set_direction(struct udevice *dev, unsigned offset,
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment