Skip to content
Snippets Groups Projects
  • Simon Glass's avatar
    26f50fbe
    Revert "x86: broadwell: gpio: Remove the codes to set up pin control" · 26f50fbe
    Simon Glass authored
    
    This makes the assumption that setting up pinctrl in cpu_init_r() is safe.
    On samus we need GPIOs before relocation in order to support power control.
    This commit fixes the following message on boot:
    
       initcall sequence ffe5c6f4 failed at call ffe01d3d (err=-1)
       ### ERROR ### Please RESET the board ###
    
    In any case it seems better to leave init to driver model, so that it can
    pick up the GPIO driver when it needs it. Since pinctrl is a dependency of
    the GPIO driver, we may as well put the dependency there and avoid these
    problems.
    
    This reverts commit 9769e05b.
    
    Signed-off-by: default avatarSimon Glass <sjg@chromium.org>
    Reviewed-by: default avatarBin Meng <bmeng.cn@gmail.com>
    26f50fbe
    History
    Revert "x86: broadwell: gpio: Remove the codes to set up pin control"
    Simon Glass authored
    
    This makes the assumption that setting up pinctrl in cpu_init_r() is safe.
    On samus we need GPIOs before relocation in order to support power control.
    This commit fixes the following message on boot:
    
       initcall sequence ffe5c6f4 failed at call ffe01d3d (err=-1)
       ### ERROR ### Please RESET the board ###
    
    In any case it seems better to leave init to driver model, so that it can
    pick up the GPIO driver when it needs it. Since pinctrl is a dependency of
    the GPIO driver, we may as well put the dependency there and avoid these
    problems.
    
    This reverts commit 9769e05b.
    
    Signed-off-by: default avatarSimon Glass <sjg@chromium.org>
    Reviewed-by: default avatarBin Meng <bmeng.cn@gmail.com>