Skip to content
Snippets Groups Projects
  • Masahiro Yamada's avatar
    085be482
    ARM: revive CONFIG_USE_ARCH_MEMCPY/MEMSET for UniPhier and Tegra · 085be482
    Masahiro Yamada authored
    
    Commit be72591b ("Kconfig: Move USE_ARCH_MEMCPY/MEMSET to
    Kconfig") is misconversion.
    
    The original logic in include/configs/uniphier.h was as follows:
    
      #if !defined(CONFIG_SPL_BUILD) && !defined(CONFIG_ARM64)
      #define CONFIG_USE_ARCH_MEMSET
      #define CONFIG_USE_ARCH_MEMCPY
      #endif
    
    This means those configs were enabled when building U-Boot proper,
    but disabled when building SPL.  Likewise for Tegra.
    
    Now "depends on !SPL" prevents any boards with SPL support
    from reaching these options.  This changed the behavior for
    UniPhier and Tegra SoC family.
    
    Please notice these two options only control the U-Boot proper
    build.  As you see arch/arm/Makefile, ARM-specific memset/memcpy
    are never compiled for SPL.  So, __HAVE_ARCH_MEMCPY/MEMSET should
    not set for SPL.
    
    Fixes: be72591b ("Kconfig: Move USE_ARCH_MEMCPY/MEMSET to Kconfig")
    Signed-off-by: default avatarMasahiro Yamada <yamada.masahiro@socionext.com>
    Reviewed-by: default avatarFabio Estevam <fabio.estevam@nxp.com>
    085be482
    History
    ARM: revive CONFIG_USE_ARCH_MEMCPY/MEMSET for UniPhier and Tegra
    Masahiro Yamada authored
    
    Commit be72591b ("Kconfig: Move USE_ARCH_MEMCPY/MEMSET to
    Kconfig") is misconversion.
    
    The original logic in include/configs/uniphier.h was as follows:
    
      #if !defined(CONFIG_SPL_BUILD) && !defined(CONFIG_ARM64)
      #define CONFIG_USE_ARCH_MEMSET
      #define CONFIG_USE_ARCH_MEMCPY
      #endif
    
    This means those configs were enabled when building U-Boot proper,
    but disabled when building SPL.  Likewise for Tegra.
    
    Now "depends on !SPL" prevents any boards with SPL support
    from reaching these options.  This changed the behavior for
    UniPhier and Tegra SoC family.
    
    Please notice these two options only control the U-Boot proper
    build.  As you see arch/arm/Makefile, ARM-specific memset/memcpy
    are never compiled for SPL.  So, __HAVE_ARCH_MEMCPY/MEMSET should
    not set for SPL.
    
    Fixes: be72591b ("Kconfig: Move USE_ARCH_MEMCPY/MEMSET to Kconfig")
    Signed-off-by: default avatarMasahiro Yamada <yamada.masahiro@socionext.com>
    Reviewed-by: default avatarFabio Estevam <fabio.estevam@nxp.com>