Skip to content
Snippets Groups Projects

WIP: (conditional) addition of SSD installation page, some code-reorganizations, fix of stack sidebar tabbing, exit directly without cleanup script

Open plom requested to merge plom_experiments into main

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
1000 1000 if got_nvme {
1001 1001 build_encrypt_page(&stack, &window);
1002 1002 }
1003
1004 let key_ctrl = gtk::EventControllerKey::new();
1005 window.add_controller(key_ctrl.clone());
1006 key_ctrl.connect_key_pressed(move |_a, key, _b, _c| {
1007 if key == gdk::Key::Tab || key == gdk::Key::ISO_Left_Tab {
1008 match GtkWindowExt::focus(&window) {
1009 Some(w) if w.is::<gtk::ListBoxRow>() && w.parent().unwrap().parent().unwrap().parent().unwrap().parent().unwrap().is::<StackSidebar>() => {
  • This parent().unwrap() cascade is really something! (This would panic on any ListBox that doesn't have that many parents, right?)

    Edited by minute
  • Author Maintainer

    From my GTK experiments, it accurately represents the depth any ListBoxRow should find itself in, so the unwrap() /should/ never panic. But I guess it's better to be safe than sorry, so I'll replace them with some more graceful handling.

    Edited by plom
  • Author Maintainer

    @mntmn New pattern: !11 (d5009180)

    Edited by plom
  • Please register or sign in to reply
  • plom changed title from WIP: addition of encryption page (and some code re-organizations) to WIP: addition of encryption page, some code-reorganizations, fix of stack sidebar tabbing

    changed title from WIP: addition of encryption page (and some code re-organizations) to WIP: addition of encryption page, some code-reorganizations, fix of stack sidebar tabbing

  • plom added 1 commit

    added 1 commit

    • d5009180 - In Stack Sidebar tabbing, make test for focused widget's ancestry more forgiving.

    Compare with previous version

  • plom mentioned in commit 364f2d21

    mentioned in commit 364f2d21

  • plom added 1 commit

    added 1 commit

    • f7bcb94c - Remove key event controller from window on its closing, so app can quit properly.

    Compare with previous version

  • plom added 2 commits

    added 2 commits

    • 0ea7915f - Remove cleanup script calling, close window directly on finish.
    • 2fe8be77 - To testing script, add wizard exit code display.

    Compare with previous version

  • plom changed title from WIP: addition of encryption page, some code-reorganizations, fix of stack sidebar tabbing to WIP: addition of encryption page, some code-reorganizations, fix of stack sidebar tabbing, exit directly without cleanup script

    changed title from WIP: addition of encryption page, some code-reorganizations, fix of stack sidebar tabbing to WIP: addition of encryption page, some code-reorganizations, fix of stack sidebar tabbing, exit directly without cleanup script

  • plom added 1 commit

    added 1 commit

    • 172489b6 - Rename Encryption to SSD installation.

    Compare with previous version

  • plom added 1 commit

    added 1 commit

    • 0120156e - Only enable SSD installation tab if proper nvme device, model name.

    Compare with previous version

  • plom added 1 commit

    added 1 commit

    • 5ed15c20 - Only enable SSD installation after successful completion of keyboard,...

    Compare with previous version

  • plom changed title from WIP: addition of encryption page, some code-reorganizations, fix of stack sidebar tabbing, exit directly without cleanup script to WIP: (conditional) addition of SSD installation page, some code-reorganizations, fix of stack sidebar tabbing, exit directly without cleanup script

    changed title from WIP: addition of encryption page, some code-reorganizations, fix of stack sidebar tabbing, exit directly without cleanup script to WIP: (conditional) addition of SSD installation page, some code-reorganizations, fix of stack sidebar tabbing, exit directly without cleanup script

  • Please register or sign in to reply
    Loading