WIP: (conditional) addition of SSD installation page, some code-reorganizations, fix of stack sidebar tabbing, exit directly without cleanup script
Merge request reports
Activity
Filter activity
1000 1000 if got_nvme { 1001 1001 build_encrypt_page(&stack, &window); 1002 1002 } 1003 1004 let key_ctrl = gtk::EventControllerKey::new(); 1005 window.add_controller(key_ctrl.clone()); 1006 key_ctrl.connect_key_pressed(move |_a, key, _b, _c| { 1007 if key == gdk::Key::Tab || key == gdk::Key::ISO_Left_Tab { 1008 match GtkWindowExt::focus(&window) { 1009 Some(w) if w.is::<gtk::ListBoxRow>() && w.parent().unwrap().parent().unwrap().parent().unwrap().parent().unwrap().is::<StackSidebar>() => { This parent().unwrap() cascade is really something! (This would panic on any ListBox that doesn't have that many parents, right?)
Edited by minuteFrom my GTK experiments, it accurately represents the depth any ListBoxRow should find itself in, so the unwrap() /should/ never panic. But I guess it's better to be safe than sorry, so I'll replace them with some more graceful handling.
Edited by plom@mntmn New pattern: !11 (d5009180)
Edited by plom
added 1 commit
- d5009180 - In Stack Sidebar tabbing, make test for focused widget's ancestry more forgiving.
mentioned in commit 364f2d21
added 1 commit
- f7bcb94c - Remove key event controller from window on its closing, so app can quit properly.
added 1 commit
- 0120156e - Only enable SSD installation tab if proper nvme device, model name.
added 1 commit
- 5ed15c20 - Only enable SSD installation after successful completion of keyboard,...
Please register or sign in to reply