Skip to content
Snippets Groups Projects
Commit fa6e0ecb authored by Holger Brunck's avatar Holger Brunck Committed by Albert ARIBAUD
Browse files

arm/km: fix wrong error handling


miiphy_read and miiphy_write are returning 0 on success.

Signed-off-by: default avatarHolger Brunck <holger.brunck@keymile.com>
Acked-by: default avatarValentin Longchamp <valentin.longchamp@keymile.com>
parent 56cde177
No related branches found
No related tags found
No related merge requests found
...@@ -318,15 +318,15 @@ void reset_phy(void) ...@@ -318,15 +318,15 @@ void reset_phy(void)
return; return;
/* RGMII clk transition on data stable */ /* RGMII clk transition on data stable */
if (!miiphy_read(name, CONFIG_PHY_BASE_ADR, PHY_SPEC_CTRL_REG, &reg)) if (miiphy_read(name, CONFIG_PHY_BASE_ADR, PHY_SPEC_CTRL_REG, &reg))
printf("Error reading PHY spec ctrl reg\n"); printf("Error reading PHY spec ctrl reg\n");
if (!miiphy_write(name, CONFIG_PHY_BASE_ADR, PHY_SPEC_CTRL_REG, if (miiphy_write(name, CONFIG_PHY_BASE_ADR, PHY_SPEC_CTRL_REG,
reg | PHY_RGMII_CLK_STABLE | PHY_CLSA)) reg | PHY_RGMII_CLK_STABLE | PHY_CLSA))
printf("Error writing PHY spec ctrl reg\n"); printf("Error writing PHY spec ctrl reg\n");
/* leds setup */ /* leds setup */
if (!miiphy_write(name, CONFIG_PHY_BASE_ADR, PHY_LED_SEL_REG, if (miiphy_write(name, CONFIG_PHY_BASE_ADR, PHY_LED_SEL_REG,
PHY_LED0_LINK | PHY_LED1_ACT | PHY_LED2_INT)) PHY_LED0_LINK | PHY_LED1_ACT | PHY_LED2_INT))
printf("Error writing PHY LED reg\n"); printf("Error writing PHY LED reg\n");
/* reset the phy */ /* reset the phy */
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment