Skip to content
Snippets Groups Projects
Commit e491a71e authored by Peter Tyser's avatar Peter Tyser Committed by Wolfgang Denk
Browse files

Check for NULL prompt in readline_into_buffer()


Previously, passing readline() or readline_into_buffer() a NULL 'prompt'
parameter would result in puts() printing garbage when
CONFIG_CMDLINE_EDITING was enabled.

Note that no board currently triggers this bug.  Enabling
CONFIG_CMDLINE_EDITING on some boards (eg bab7xx) would result in
the bug appearing.  This change is only intended to prevent someone
from running into this issue in the future.

Signed-off-by: default avatarPeter Tyser <ptyser@xes-inc.com>
parent 16d1c107
Branches
Tags
No related merge requests found
...@@ -964,6 +964,7 @@ int readline_into_buffer (const char *const prompt, char * buffer) ...@@ -964,6 +964,7 @@ int readline_into_buffer (const char *const prompt, char * buffer)
initted = 1; initted = 1;
} }
if (prompt)
puts (prompt); puts (prompt);
rc = cread_line(prompt, p, &len); rc = cread_line(prompt, p, &len);
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment