Skip to content
Snippets Groups Projects
Commit e0e89e23 authored by Mike Dunn's avatar Mike Dunn Committed by Marek Vasut
Browse files

pxa27x_udc: remove call to unimplemented set_GPIO_mode()


If CONFIG_USB_DEV_PULLUP_GPIO is defined, a link error occurs because the
set_GPIO_mode() helper function is not implemented.  This function doesn't do
much except make the code a little more readable, so I just manually coded its
equivalent and removed the prototype from the header file.  It is invoked no
where else in the code.

While I was at it, I noticed that two other function prototypes in the same
header file are also neither implemented nor invoked anywhere, so I removed them
as well.

Signed-off-by: default avatarMike Dunn <mikedunn@newsguy.com>
parent 86e929e8
No related branches found
No related tags found
No related merge requests found
...@@ -77,17 +77,6 @@ ...@@ -77,17 +77,6 @@
#define GPIO_FALLING_EDGE 1 #define GPIO_FALLING_EDGE 1
#define GPIO_RISING_EDGE 2 #define GPIO_RISING_EDGE 2
#define GPIO_BOTH_EDGES 3 #define GPIO_BOTH_EDGES 3
extern void set_GPIO_IRQ_edge( int gpio_nr, int edge_mask );
/*
* Handy routine to set GPIO alternate functions
*/
extern void set_GPIO_mode( int gpio_mode );
/*
* return current lclk frequency in units of 10kHz
*/
extern unsigned int get_lclk_frequency_10khz(void);
#endif #endif
......
...@@ -610,7 +610,9 @@ void udc_connect(void) ...@@ -610,7 +610,9 @@ void udc_connect(void)
#ifdef CONFIG_USB_DEV_PULLUP_GPIO #ifdef CONFIG_USB_DEV_PULLUP_GPIO
/* Turn on the USB connection by enabling the pullup resistor */ /* Turn on the USB connection by enabling the pullup resistor */
set_GPIO_mode(CONFIG_USB_DEV_PULLUP_GPIO | GPIO_OUT); writel(readl(GPDR(CONFIG_USB_DEV_PULLUP_GPIO))
| GPIO_bit(CONFIG_USB_DEV_PULLUP_GPIO),
GPDR(CONFIG_USB_DEV_PULLUP_GPIO));
writel(GPIO_bit(CONFIG_USB_DEV_PULLUP_GPIO), GPSR(CONFIG_USB_DEV_PULLUP_GPIO)); writel(GPIO_bit(CONFIG_USB_DEV_PULLUP_GPIO), GPSR(CONFIG_USB_DEV_PULLUP_GPIO));
#else #else
/* Host port 2 transceiver D+ pull up enable */ /* Host port 2 transceiver D+ pull up enable */
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment