Skip to content
Snippets Groups Projects
Commit bb08a6e7 authored by Peng Fan's avatar Peng Fan Committed by Tom Rini
Browse files

common: cli_simple: use strlcpy instead of strcpy


Report Coverity log:
Destination buffer too small (STRING_OVERFLOW)
string_overflow: You might overrun the 1024 byte destination string
lastcommand by writing 1025 bytes from console_buffer

Signed-off-by: default avatarPeng Fan <van.freenix@gmail.com>
Cc: Heiko Schocher <hs@denx.de>
Cc: Simon Glass <sjg@chromium.org>
Cc: Tom Rini <trini@konsulko.com>
Reviewed-by: default avatarSimon Glass <sjg@chromium.org>
parent 247be79a
No related branches found
No related tags found
No related merge requests found
...@@ -276,7 +276,8 @@ void cli_simple_loop(void) ...@@ -276,7 +276,8 @@ void cli_simple_loop(void)
flag = 0; /* assume no special flags for now */ flag = 0; /* assume no special flags for now */
if (len > 0) if (len > 0)
strcpy(lastcommand, console_buffer); strlcpy(lastcommand, console_buffer,
CONFIG_SYS_CBSIZE + 1);
else if (len == 0) else if (len == 0)
flag |= CMD_FLAG_REPEAT; flag |= CMD_FLAG_REPEAT;
#ifdef CONFIG_BOOT_RETRY_TIME #ifdef CONFIG_BOOT_RETRY_TIME
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment