Skip to content
Snippets Groups Projects
Commit aab0db08 authored by Bin Meng's avatar Bin Meng Committed by Marek Vasut
Browse files

usb: xhci: Add input slot context in xhci_set_configuration()


A valid input slot context for a 'configure endpoint' command requires
the 'Context Entries' field to be initialized to the index of the last
valid endpoint context that is defined by the target configuration. We
set up the 'Context Entries' field, but we forget to include the input
slot context in the input control context 'Add Context flags' bitmap.
So xHC will simply ignore input slot context and continue using its own
which contains old information of the device.

Signed-off-by: default avatarBin Meng <bmeng.cn@gmail.com>
Reviewed-by: default avatarSimon Glass <sjg@chromium.org>
Reviewed-by: default avatarStefan Roese <sr@denx.de>
Tested-by: default avatarStefan Roese <sr@denx.de>
parent 209b98de
Branches
Tags
No related merge requests found
......@@ -332,8 +332,8 @@ static int xhci_set_configuration(struct usb_device *udev)
ifdesc = &udev->config.if_desc[0];
ctrl_ctx = xhci_get_input_control_ctx(in_ctx);
/* Zero the input context control */
ctrl_ctx->add_flags = 0;
/* Initialize the input context control */
ctrl_ctx->add_flags = cpu_to_le32(SLOT_FLAG);
ctrl_ctx->drop_flags = 0;
/* EP_FLAG gives values 1 & 4 for EP1OUT and EP2IN */
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment