Skip to content
Snippets Groups Projects
Commit a6e98104 authored by Mirza, Taimoor's avatar Mirza, Taimoor Committed by Tom Rini
Browse files

tools/mkimage: Fix DTC run command to handle file names with space


fit_handle_file function does not quote input and output files while preparing
command to run DTC to convert .its to .itb. This results in a failure if input
or output files contain spaces in their names. Quote input and output files in
DTC command to avoid this failure.

Signed-off-by: default avatarMirza, Taimoor <Taimoor_Mirza@mentor.com>
parent 409f05f2
Branches
Tags
No related merge requests found
......@@ -651,11 +651,11 @@ static int fit_handle_file(struct image_tool_params *params)
*cmd = '\0';
} else if (params->datafile) {
/* dtc -I dts -O dtb -p 500 datafile > tmpfile */
snprintf(cmd, sizeof(cmd), "%s %s %s > %s",
snprintf(cmd, sizeof(cmd), "%s %s \"%s\" > \"%s\"",
MKIMAGE_DTC, params->dtc, params->datafile, tmpfile);
debug("Trying to execute \"%s\"\n", cmd);
} else {
snprintf(cmd, sizeof(cmd), "cp %s %s",
snprintf(cmd, sizeof(cmd), "cp \"%s\" \"%s\"",
params->imagefile, tmpfile);
}
if (*cmd && system(cmd) == -1) {
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment