Skip to content
Snippets Groups Projects
Commit a1eac57a authored by Phil Sutter's avatar Phil Sutter Committed by Scott Wood
Browse files

common/env_nand.c: calculate crc only when readenv was OK


Calculating the checksum of incompletely read data is useless.

Signed-off-by: default avatarPhil Sutter <phil.sutter@viprinet.com>
[scottwood@freescale.com: minor formatting fix]
Signed-off-by: default avatarScott Wood <scottwood@freescale.com>
parent b76a147b
No related branches found
No related tags found
No related merge requests found
......@@ -352,8 +352,10 @@ void env_relocate_spec(void)
puts("*** Warning - some problems detected "
"reading environment; recovered successfully\n");
crc1_ok = crc32(0, tmp_env1->data, ENV_SIZE) == tmp_env1->crc;
crc2_ok = crc32(0, tmp_env2->data, ENV_SIZE) == tmp_env2->crc;
crc1_ok = !read1_fail &&
(crc32(0, tmp_env1->data, ENV_SIZE) == tmp_env1->crc);
crc2_ok = !read2_fail &&
(crc32(0, tmp_env2->data, ENV_SIZE) == tmp_env2->crc);
if (!crc1_ok && !crc2_ok) {
set_default_env("!bad CRC");
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment