mmc: Split mmc struct, rework mmc initialization (v2)
The way that struct mmc was implemented was a bit of a mess;
configuration and internal state all jumbled up in a single structure.
On top of that the way initialization is done with mmc_register leads
to a lot of duplicated code in drivers.
Typically the initialization got something like this in every driver.
struct mmc *mmc = malloc(sizeof(struct mmc));
memset(mmc, 0, sizeof(struct mmc);
/* fill in fields of mmc struct */
/* store private data pointer */
mmc_register(mmc);
By using the new mmc_create call one just passes an mmc config struct
and an optional private data pointer like this:
struct mmc = mmc_create(&cfg, priv);
All in tree drivers have been updated to the new form, and expect
mmc_register to go away before long.
Changes since v1:
* Use calloc instead of manually calling memset.
* Mark mmc_register as deprecated.
Signed-off-by:
Pantelis Antoniou <panto@antoniou-consulting.com>
Showing
- arch/arm/include/asm/arch-davinci/sdmmc_defs.h 1 addition, 0 deletionsarch/arm/include/asm/arch-davinci/sdmmc_defs.h
- arch/arm/include/asm/arch-tegra/tegra_mmc.h 4 additions, 0 deletionsarch/arm/include/asm/arch-tegra/tegra_mmc.h
- common/cmd_mmc.c 1 addition, 1 deletioncommon/cmd_mmc.c
- common/cmd_mmc_spi.c 1 addition, 1 deletioncommon/cmd_mmc_spi.c
- drivers/mmc/arm_pl180_mmci.c 21 additions, 19 deletionsdrivers/mmc/arm_pl180_mmci.c
- drivers/mmc/arm_pl180_mmci.h 4 additions, 0 deletionsdrivers/mmc/arm_pl180_mmci.h
- drivers/mmc/bfin_sdh.c 15 additions, 16 deletionsdrivers/mmc/bfin_sdh.c
- drivers/mmc/davinci_mmc.c 12 additions, 18 deletionsdrivers/mmc/davinci_mmc.c
- drivers/mmc/dw_mmc.c 21 additions, 29 deletionsdrivers/mmc/dw_mmc.c
- drivers/mmc/fsl_esdhc.c 27 additions, 28 deletionsdrivers/mmc/fsl_esdhc.c
- drivers/mmc/ftsdc010_mci.c 22 additions, 32 deletionsdrivers/mmc/ftsdc010_mci.c
- drivers/mmc/gen_atmel_mci.c 26 additions, 17 deletionsdrivers/mmc/gen_atmel_mci.c
- drivers/mmc/mmc.c 63 additions, 35 deletionsdrivers/mmc/mmc.c
- drivers/mmc/mmc_spi.c 21 additions, 19 deletionsdrivers/mmc/mmc_spi.c
- drivers/mmc/mmc_write.c 2 additions, 1 deletiondrivers/mmc/mmc_write.c
- drivers/mmc/mxcmmc.c 15 additions, 20 deletionsdrivers/mmc/mxcmmc.c
- drivers/mmc/mxsmmc.c 18 additions, 20 deletionsdrivers/mmc/mxsmmc.c
- drivers/mmc/omap_hsmmc.c 32 additions, 23 deletionsdrivers/mmc/omap_hsmmc.c
- drivers/mmc/pxa_mmc_gen.c 29 additions, 32 deletionsdrivers/mmc/pxa_mmc_gen.c
- drivers/mmc/sdhci.c 36 additions, 37 deletionsdrivers/mmc/sdhci.c
Loading
Please register or sign in to comment