Skip to content
Snippets Groups Projects
Commit 8aa41363 authored by Simon Glass's avatar Simon Glass
Browse files

patman: Format checkpatch messages for IDE throwback


It is convenient to be able to deal with checkpatch warnings in the same
way as build warnings. Tools such as emacs and kate can quickly locate
the source file and line automatically.

To achieve this, adjust the format to match the C compiler, and output to
stderr.

Signed-off-by: default avatarSimon Glass <sjg@chromium.org>
parent 6b6024a3
Branches
Tags
No related merge requests found
......@@ -138,7 +138,7 @@ def GetWarningMsg(col, msg_type, fname, line, msg):
msg_type = col.Color(col.RED, msg_type)
elif msg_type == 'check':
msg_type = col.Color(col.MAGENTA, msg_type)
return '%s: %s,%d: %s' % (msg_type, fname, line, msg)
return '%s:%d: %s: %s\n' % (fname, line, msg_type, msg)
def CheckPatches(verbose, args):
'''Run the checkpatch.pl script on each patch'''
......@@ -157,7 +157,8 @@ def CheckPatches(verbose, args):
result.checks):
print("Internal error: some problems lost")
for item in result.problems:
print(GetWarningMsg(col, item.get('type', '<unknown>'),
sys.stderr.write(
GetWarningMsg(col, item.get('type', '<unknown>'),
item.get('file', '<unknown>'),
item.get('line', 0), item.get('msg', 'message')))
print
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment