Skip to content
Snippets Groups Projects
Commit 896720ce authored by Nikhil Badola's avatar Nikhil Badola Committed by York Sun
Browse files

fsl/usb: Increase TXFIFOTHRESH value for usb write in T4 Rev 2.0


Increase TXFIFOTHRES field value in TXFILLTUNING register of usb for T4 Rev 2.0.
This decreases data burst rate with which data packets are posted from the TX
latency FIFO to compensate for latencies in DDR pipeline during DMA.
This avoids Tx buffer underruns and leads to successful usb writes

Signed-off-by: default avatarRamneek Mehresh <ramneek.mehresh@freescale.com>
Signed-off-by: default avatarNikhil Badola <nikhil.badola@freescale.com>
Reviewed-by: default avatarYork Sun <yorksun@freescale.com>
parent 55153d6c
No related branches found
No related tags found
No related merge requests found
......@@ -18,6 +18,8 @@
#include "ehci.h"
static void set_txfifothresh(struct usb_ehci *, u32);
/* Check USB PHY clock valid */
static int usb_phy_clk_valid(struct usb_ehci *ehci)
{
......@@ -123,6 +125,10 @@ int ehci_hcd_init(int index, enum usb_init_type init,
in_le32(&ehci->usbmode);
if (SVR_SOC_VER(get_svr()) == SVR_T4240 &&
IS_SVR_REV(get_svr(), 2, 0))
set_txfifothresh(ehci, TXFIFOTHRESH);
return 0;
}
......@@ -134,3 +140,17 @@ int ehci_hcd_stop(int index)
{
return 0;
}
/*
* Setting the value of TXFIFO_THRESH field in TXFILLTUNING register
* to counter DDR latencies in writing data into Tx buffer.
* This prevents Tx buffer from getting underrun
*/
static void set_txfifothresh(struct usb_ehci *ehci, u32 txfifo_thresh)
{
u32 cmd;
cmd = ehci_readl(&ehci->txfilltuning);
cmd &= ~TXFIFO_THRESH_MASK;
cmd |= TXFIFO_THRESH(txfifo_thresh);
ehci_writel(&ehci->txfilltuning, cmd);
}
......@@ -163,6 +163,13 @@
#define CONFIG_SYS_FSL_USB2_ADDR 0
#endif
/*
* Increasing TX FIFO threshold value from 2 to 4 decreases
* data burst rate with which data packets are posted from the TX
* latency FIFO to compensate for latencies in DDR pipeline during DMA
*/
#define TXFIFOTHRESH 4
/*
* USB Registers
*/
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment