Skip to content
Snippets Groups Projects
Commit 87a40b6e authored by Stefan Brüns's avatar Stefan Brüns Committed by Tom Rini
Browse files

ext4: Fix memory leak in case of failure


temp_ptr should always be freed, even if the function is left via
goto fail.

Signed-off-by: default avatarStefan Brüns <stefan.bruens@rwth-aachen.de>
Reviewed-by: default avatarLukasz Majewski <l.majewski@samsung.com>
parent 0ceef3d3
No related branches found
No related tags found
No related merge requests found
......@@ -974,7 +974,6 @@ int ext4fs_write(const char *fname, unsigned char *buffer,
sizeof(struct ext2_inode));
if (ext4fs_put_metadata(temp_ptr, parent_itable_blkno))
goto fail;
free(temp_ptr);
} else {
/*
* If parent and child fall in same inode table block
......@@ -985,7 +984,6 @@ int ext4fs_write(const char *fname, unsigned char *buffer,
gd_index--;
if (ext4fs_put_metadata(temp_ptr, itable_blkno))
goto fail;
free(temp_ptr);
}
ext4fs_update();
ext4fs_deinit();
......@@ -996,6 +994,7 @@ int ext4fs_write(const char *fname, unsigned char *buffer,
fs->curr_inode_no = 0;
free(inode_buffer);
free(g_parent_inode);
free(temp_ptr);
g_parent_inode = NULL;
return 0;
......@@ -1003,6 +1002,7 @@ fail:
ext4fs_deinit();
free(inode_buffer);
free(g_parent_inode);
free(temp_ptr);
g_parent_inode = NULL;
return -1;
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment