Skip to content
Snippets Groups Projects
Commit 8639e34d authored by Alexey Brodkin's avatar Alexey Brodkin Committed by Tom Rini
Browse files

part: Allocate only one legacy_mbr buffer


Commit ff98cb90 ("part: extract MBR signature from partitions")
blindly switched allocated by ALLOC_CACHE_ALIGN_BUFFER buffer type from
"unsigned char" to "legacy_mbr" which caused allocation of size =
(typeof(legacy_mbr) * dev_desc->blksize) instead of just space enough
for "legacy_mbr" structure.

Signed-off-by: default avatarAlexey Brodkin <abrodkin@synopsys.com>
Cc: Rob Clark <robdclark@gmail.com>
Cc: Peter Jones <pjones@redhat.com>
Cc: Alexander Graf <agraf@suse.de>
Cc: Tom Rini <trini@konsulko.com>
parent 6808ef9a
No related branches found
No related tags found
No related merge requests found
...@@ -90,7 +90,7 @@ static int test_block_type(unsigned char *buffer) ...@@ -90,7 +90,7 @@ static int test_block_type(unsigned char *buffer)
static int part_test_dos(struct blk_desc *dev_desc) static int part_test_dos(struct blk_desc *dev_desc)
{ {
#ifndef CONFIG_SPL_BUILD #ifndef CONFIG_SPL_BUILD
ALLOC_CACHE_ALIGN_BUFFER(legacy_mbr, mbr, dev_desc->blksz); ALLOC_CACHE_ALIGN_BUFFER(legacy_mbr, mbr, 1);
if (blk_dread(dev_desc, 0, 1, (ulong *)mbr) != 1) if (blk_dread(dev_desc, 0, 1, (ulong *)mbr) != 1)
return -1; return -1;
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment