Skip to content
Snippets Groups Projects
Commit 7cde9f35 authored by Alexey Brodkin's avatar Alexey Brodkin Committed by Michal Simek
Browse files

block: systemace: Added missing "else" in "ace_writew"


System ACE compact flash controller supports either 8-bit (default) or
16-bit data transfers. And in corresponding driver we need to implement
read/write of 16-bit data words properly for both modes of operation.

In existing code if width==8 both branches get executed which may cause
unexpected behavior of SystemAce controller.

Addition of "else" fixes described issue and execution is done as
expected for both (8-bit and 16-bit) data bus widths.

Signed-off-by: default avatarAlexey Brodkin <alexey.brodkin@gmail.com>
Signed-off-by: default avatarMichal Simek <michal.simek@xilinx.com>
parent 6ad77d88
No related branches found
No related tags found
No related merge requests found
...@@ -65,8 +65,8 @@ static void ace_writew(u16 val, unsigned off) ...@@ -65,8 +65,8 @@ static void ace_writew(u16 val, unsigned off)
writeb(val, base + off); writeb(val, base + off);
writeb(val >> 8, base + off + 1); writeb(val >> 8, base + off + 1);
#endif #endif
} } else
out16(base + off, val); out16(base + off, val);
} }
static u16 ace_readw(unsigned off) static u16 ace_readw(unsigned off)
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment