Skip to content
Snippets Groups Projects
Commit 6461f45b authored by xypron.glpk@gmx.de's avatar xypron.glpk@gmx.de Committed by Bin Meng
Browse files

x86: ivybridge: remove unused uma_memory_size


The value of uma_memory_size depends on an undefined value
from the stack. The value of uma_memory_size is changed but
never used.

So simply remove this superfluous code.

The problem was indicated by cppcheck.

Signed-off-by: default avatarHeinrich Schuchardt <xypron.glpk@gmx.de>
Reviewed-by: default avatarBin Meng <bmeng.cn@gmail.com>
Reviewed-by: default avatarSimon Glass <sjg@chromium.org>
parent 72436892
No related branches found
No related tags found
No related merge requests found
...@@ -233,7 +233,6 @@ static int sdram_find(struct udevice *dev) ...@@ -233,7 +233,6 @@ static int sdram_find(struct udevice *dev)
uint32_t tseg_base, uma_size, tolud; uint32_t tseg_base, uma_size, tolud;
uint64_t tom, me_base, touud; uint64_t tom, me_base, touud;
uint64_t uma_memory_base = 0; uint64_t uma_memory_base = 0;
uint64_t uma_memory_size;
unsigned long long tomk; unsigned long long tomk;
uint16_t ggc; uint16_t ggc;
u32 val; u32 val;
...@@ -298,7 +297,6 @@ static int sdram_find(struct udevice *dev) ...@@ -298,7 +297,6 @@ static int sdram_find(struct udevice *dev)
tolud += uma_size << 10; tolud += uma_size << 10;
/* UMA starts at old TOLUD */ /* UMA starts at old TOLUD */
uma_memory_base = tomk * 1024ULL; uma_memory_base = tomk * 1024ULL;
uma_memory_size = uma_size * 1024ULL;
debug("ME UMA base %llx size %uM\n", me_base, uma_size >> 10); debug("ME UMA base %llx size %uM\n", me_base, uma_size >> 10);
} }
...@@ -312,13 +310,11 @@ static int sdram_find(struct udevice *dev) ...@@ -312,13 +310,11 @@ static int sdram_find(struct udevice *dev)
debug("%uM UMA", uma_size >> 10); debug("%uM UMA", uma_size >> 10);
tomk -= uma_size; tomk -= uma_size;
uma_memory_base = tomk * 1024ULL; uma_memory_base = tomk * 1024ULL;
uma_memory_size += uma_size * 1024ULL;
/* GTT Graphics Stolen Memory Size (GGMS) */ /* GTT Graphics Stolen Memory Size (GGMS) */
uma_size = ((ggc >> 8) & 0x3) * 1024ULL; uma_size = ((ggc >> 8) & 0x3) * 1024ULL;
tomk -= uma_size; tomk -= uma_size;
uma_memory_base = tomk * 1024ULL; uma_memory_base = tomk * 1024ULL;
uma_memory_size += uma_size * 1024ULL;
debug(" and %uM GTT\n", uma_size >> 10); debug(" and %uM GTT\n", uma_size >> 10);
} }
...@@ -327,7 +323,6 @@ static int sdram_find(struct udevice *dev) ...@@ -327,7 +323,6 @@ static int sdram_find(struct udevice *dev)
uma_size = (uma_memory_base - tseg_base) >> 10; uma_size = (uma_memory_base - tseg_base) >> 10;
tomk -= uma_size; tomk -= uma_size;
uma_memory_base = tomk * 1024ULL; uma_memory_base = tomk * 1024ULL;
uma_memory_size += uma_size * 1024ULL;
debug("TSEG base 0x%08x size %uM\n", tseg_base, uma_size >> 10); debug("TSEG base 0x%08x size %uM\n", tseg_base, uma_size >> 10);
debug("Available memory below 4GB: %lluM\n", tomk >> 10); debug("Available memory below 4GB: %lluM\n", tomk >> 10);
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment