Skip to content
Snippets Groups Projects
Commit 38bd80b4 authored by Simon Glass's avatar Simon Glass Committed by Wolfgang Denk
Browse files

net: Fix arguments in tftpput command


The switch to strict_strtoul() was not done correctly - this fixes
the compile error when CONFIG_CMD_TFTPPUT is active.

There appears to very little use of strict_strtoul() in commands, so
it might be easier to switch to simple_strtoul(). If not, we should
decide the best way to use strict_strtoul(). For now I have added a
friendly message which will of course increase code size.

Signed-off-by: default avatarSimon Glass <sjg@chromium.org>
parent bf0b6313
No related branches found
No related tags found
No related merge requests found
......@@ -221,8 +221,11 @@ static int netboot_common(enum proto_t proto, cmd_tbl_t *cmdtp, int argc,
#ifdef CONFIG_CMD_TFTPPUT
case 4:
save_addr = strict_strtoul(argv[1], NULL, 16);
save_size = strict_strtoul(argv[2], NULL, 16);
if (strict_strtoul(argv[1], 16, &save_addr) < 0 ||
strict_strtoul(argv[2], 16, &save_size) < 0) {
printf("Invalid address/size\n");
return cmd_usage(cmdtp);
}
copy_filename(BootFile, argv[3], sizeof(BootFile));
break;
#endif
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment