Skip to content
Snippets Groups Projects
Commit 33699df1 authored by Jerry Huang's avatar Jerry Huang Committed by Tom Rini
Browse files

part: check each variable for capability calculation


In order to calculate the capability, we use the below expression to check:
((dev_desc->lba * dev_desc->blksz)>0L)
If the capability is greater than 4GB (e.g. 8GB = 8 * 1024 * 104 * 1024),
the result will overflow, the low 32bit may be zero.

Therefore, change to check each variable to fix this potential issue.

Signed-off-by: default avatarJerry Huang <Chang-Ming.Huang@freescale.com>
parent e3ff797c
No related branches found
No related tags found
No related merge requests found
......@@ -199,7 +199,7 @@ void dev_print (block_dev_desc_t *dev_desc)
break;
}
puts ("\n");
if ((dev_desc->lba * dev_desc->blksz)>0L) {
if (dev_desc->lba > 0L && dev_desc->blksz > 0L) {
ulong mb, mb_quot, mb_rem, gb, gb_quot, gb_rem;
lbaint_t lba;
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment