Skip to content
Snippets Groups Projects
Commit 31417f0e authored by York Sun's avatar York Sun Committed by Tom Rini
Browse files

cmd: ethsw: Fix out-of-bounds error


The for loop in cmd_keywords_opt_check() seems to use wrong array to
set boundary, reported by Coverity analysis.

Signed-off-by: default avatarYork Sun <york.sun@nxp.com>
CC: Joe Hershberger <joe.hershberger@ni.com>
CC: Tom Rini <trini@konsulko.com>
CC: Prabhakar Kushwaha <prabhakar.kushwaha@nxp.com>
Reported-by: Coverity (CID: 163251)
Reviewed-by: default avatarTom Rini <trini@konsulko.com>
Acked-by: default avatarJoe Hershberger <joe.hershberger@ni.com>
parent 19de2deb
No related branches found
No related tags found
No related merge requests found
...@@ -915,7 +915,7 @@ static void cmd_keywords_opt_check(const struct ethsw_command_def *parsed_cmd, ...@@ -915,7 +915,7 @@ static void cmd_keywords_opt_check(const struct ethsw_command_def *parsed_cmd,
* check if our command's optional keywords match the optional * check if our command's optional keywords match the optional
* keywords of an available command * keywords of an available command
*/ */
for (i = 0; i < ARRAY_SIZE(ethsw_cmd_def); i++) { for (i = 0; i < ARRAY_SIZE(cmd_opt_def); i++) {
keyw_opt_matched = 0; keyw_opt_matched = 0;
cmd_keyw_p = &parsed_cmd->cmd_to_keywords[keyw_opt_matched]; cmd_keyw_p = &parsed_cmd->cmd_to_keywords[keyw_opt_matched];
cmd_keyw_opt_p = &cmd_opt_def[i].cmd_keyword[keyw_opt_matched]; cmd_keyw_opt_p = &cmd_opt_def[i].cmd_keyword[keyw_opt_matched];
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment