Skip to content
Snippets Groups Projects
Commit 22a4a6c5 authored by Maxime Larocque's avatar Maxime Larocque Committed by Tom Rini
Browse files

printenv: Correct out-of-memory condition check.


In common/cmd_nvedit.c, en env_print(), the wrong type is used for len.
hexport_r() returns -1 on error (like OOM), which is converted to
0xffffffff when put in an unsigned. Said value is obviously bigger then
0, and as a result an uninitialized string is then displayed. Other
usages of hexport_r() in the code correctly uses ssize_t to keep its
return value.

Signed-off-by: default avatarMaxime Larocque <maxmtl2002@yahoo.ca>
parent 314dd4fe
No related branches found
No related tags found
No related merge requests found
......@@ -96,7 +96,7 @@ int get_env_id(void)
static int env_print(char *name, int flag)
{
char *res = NULL;
size_t len;
ssize_t len;
if (name) { /* print a single name */
ENTRY e, *ep;
......@@ -120,6 +120,7 @@ static int env_print(char *name, int flag)
}
/* should never happen */
printf("## Error: cannot export environment\n");
return 0;
}
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment