Skip to content
Snippets Groups Projects
Commit 2001b9a6 authored by Simon Glass's avatar Simon Glass Committed by Jagannadha Sutradharudu Teki
Browse files

cros_ec: Fix two bugs in the SPI implementation


An incorrect message version is passed to the EC in some cases and the
parameters of one function are switched.

Fix these problems.

Signed-off-by: default avatarSimon Glass <sjg@chromium.org>
Tested-by: default avatarAjay Kumar <ajaykumar.rs@samsung.com>
Reviewed-by: default avatarJagannadha Sutradharudu Teki <jaganna@xilinx.com>
parent a52a178f
No related branches found
No related tags found
No related merge requests found
...@@ -98,7 +98,7 @@ int cros_ec_spi_command(struct cros_ec_dev *dev, uint8_t cmd, int cmd_version, ...@@ -98,7 +98,7 @@ int cros_ec_spi_command(struct cros_ec_dev *dev, uint8_t cmd, int cmd_version,
} }
out = dev->dout; out = dev->dout;
out[0] = cmd_version; out[0] = EC_CMD_VERSION0 + cmd_version;
out[1] = cmd; out[1] = cmd;
out[2] = (uint8_t)dout_len; out[2] = (uint8_t)dout_len;
memcpy(out + 3, dout, dout_len); memcpy(out + 3, dout, dout_len);
...@@ -165,7 +165,7 @@ int cros_ec_spi_decode_fdt(struct cros_ec_dev *dev, const void *blob) ...@@ -165,7 +165,7 @@ int cros_ec_spi_decode_fdt(struct cros_ec_dev *dev, const void *blob)
*/ */
int cros_ec_spi_init(struct cros_ec_dev *dev, const void *blob) int cros_ec_spi_init(struct cros_ec_dev *dev, const void *blob)
{ {
dev->spi = spi_setup_slave_fdt(blob, dev->parent_node, dev->node); dev->spi = spi_setup_slave_fdt(blob, dev->node, dev->parent_node);
if (!dev->spi) { if (!dev->spi) {
debug("%s: Could not setup SPI slave\n", __func__); debug("%s: Could not setup SPI slave\n", __func__);
return -1; return -1;
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment