Skip to content
Snippets Groups Projects
Commit 1fb67608 authored by Simon Glass's avatar Simon Glass
Browse files

tiny-printf: Tidy up a few nits


- Rename 'w' to 'width' to make it more obvious what it is used for
- Use bool and int types instead of char to avoid register-masking on
32-bit machines

Signed-off-by: default avatarSimon Glass <sjg@chromium.org>
Reviewed-by: default avatarStefan Roese <sr@denx.de>
parent d0375f3c
No related branches found
No related tags found
No related merge requests found
......@@ -52,8 +52,8 @@ int vprintf(const char *fmt, va_list va)
if (ch != '%') {
putc(ch);
} else {
char lz = 0;
char w = 0;
bool lz = false;
int width = 0;
ch = *(fmt++);
if (ch == '0') {
......@@ -62,9 +62,9 @@ int vprintf(const char *fmt, va_list va)
}
if (ch >= '0' && ch <= '9') {
w = 0;
width = 0;
while (ch >= '0' && ch <= '9') {
w = (w * 10) + ch - '0';
width = (width * 10) + ch - '0';
ch = *fmt++;
}
}
......@@ -73,7 +73,7 @@ int vprintf(const char *fmt, va_list va)
zs = 0;
switch (ch) {
case 0:
case '\0':
goto abort;
case 'u':
case 'd':
......@@ -112,9 +112,9 @@ int vprintf(const char *fmt, va_list va)
*bf = 0;
bf = p;
while (*bf++ && w > 0)
w--;
while (w-- > 0)
while (*bf++ && width > 0)
width--;
while (width-- > 0)
putc(lz ? '0' : ' ');
if (p) {
while ((ch = *p++))
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment