serial, ns16550: bugfix: ns16550 fifo not enabled
commit: 65f83802 "serial: 16550: Add getfcr accessor" breaks u-boot commandline working with long commands sending to the board. Since the above patch, you have to setup the fcr register. For board/archs which enable OF_PLATDATA, the new field fcr in struct ns16550_platdata is not filled with a default value ... This leads in not setting up the uarts fifo, which ends in problems, when you send long commands to u-boots commandline. Detected this issue with automated tbot tests on am335x based shc board. The error does not popup, if you type commands. You need to copy&paste a long command to u-boots commandshell (or send a long command with tbot) Possible boards/plattforms with problems: ./arch/arm/cpu/arm926ejs/lpc32xx/devices.c ./arch/arm/mach-tegra/board.c ./board/overo/overo.c ./board/quipos/cairo/cairo.c ./board/logicpd/omap3som/omap3logic.c ./board/logicpd/zoom1/zoom1.c ./board/timll/devkit8000/devkit8000.c ./board/lg/sniper/sniper.c ./board/ti/beagle/beagle.c ./drivers/serial/serial_rockchip.c Signed-off-by:Heiko Schocher <hs@denx.de> Signed-off-by:
Ladislav Michl <ladis@linux-mips.org> Tested-by:
Adam Ford <aford173@gmail.com> Reviewed-by:
Tom Rini <trini@konsulko.com>
Showing
- arch/arm/cpu/arm926ejs/lpc32xx/devices.c 8 additions, 4 deletionsarch/arm/cpu/arm926ejs/lpc32xx/devices.c
- arch/arm/mach-omap2/am33xx/board.c 12 additions, 6 deletionsarch/arm/mach-omap2/am33xx/board.c
- arch/arm/mach-tegra/board.c 1 addition, 0 deletionsarch/arm/mach-tegra/board.c
- board/isee/igep00x0/igep00x0.c 2 additions, 1 deletionboard/isee/igep00x0/igep00x0.c
- board/lg/sniper/sniper.c 2 additions, 1 deletionboard/lg/sniper/sniper.c
- board/logicpd/omap3som/omap3logic.c 2 additions, 1 deletionboard/logicpd/omap3som/omap3logic.c
- board/logicpd/zoom1/zoom1.c 2 additions, 1 deletionboard/logicpd/zoom1/zoom1.c
- board/overo/overo.c 2 additions, 1 deletionboard/overo/overo.c
- board/quipos/cairo/cairo.c 2 additions, 1 deletionboard/quipos/cairo/cairo.c
- board/ti/beagle/beagle.c 2 additions, 1 deletionboard/ti/beagle/beagle.c
- board/timll/devkit8000/devkit8000.c 2 additions, 1 deletionboard/timll/devkit8000/devkit8000.c
- drivers/serial/ns16550.c 3 additions, 6 deletionsdrivers/serial/ns16550.c
- drivers/serial/serial_rockchip.c 1 addition, 0 deletionsdrivers/serial/serial_rockchip.c
- include/ns16550.h 5 additions, 0 deletionsinclude/ns16550.h
Loading
Please register or sign in to comment