Skip to content
Snippets Groups Projects
Commit 11d59fe5 authored by Ramon Fried's avatar Ramon Fried Committed by Tom Rini
Browse files

serial: serial_msm: fail probe if settings clocks fails


Failure to set the clocks will causes data abort exception when
trying to write to AHB uart registers.
This patch ensures that we don't touch these registers if clock
setting failed.

Signed-off-by: default avatarRamon Fried <ramon.fried@gmail.com>
Reviewed-by: default avatarSimon Glass <sjg@chromium.org>
parent ffada23c
No related branches found
No related tags found
No related merge requests found
...@@ -181,10 +181,12 @@ static int msm_uart_clk_init(struct udevice *dev) ...@@ -181,10 +181,12 @@ static int msm_uart_clk_init(struct udevice *dev)
static int msm_serial_probe(struct udevice *dev) static int msm_serial_probe(struct udevice *dev)
{ {
int ret;
struct msm_serial_data *priv = dev_get_priv(dev); struct msm_serial_data *priv = dev_get_priv(dev);
msm_uart_clk_init(dev); /* Ignore return value and hope clock was ret = msm_uart_clk_init(dev);
properly initialized by earlier loaders */ if (ret)
return ret;
if (readl(priv->base + UARTDM_SR) & UARTDM_SR_UART_OVERRUN) if (readl(priv->base + UARTDM_SR) & UARTDM_SR_UART_OVERRUN)
writel(UARTDM_CR_CMD_RESET_ERR, priv->base + UARTDM_CR); writel(UARTDM_CR_CMD_RESET_ERR, priv->base + UARTDM_CR);
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment