Skip to content
Snippets Groups Projects
Commit 0c54f4b7 authored by Andrew Gabbasov's avatar Andrew Gabbasov Committed by Stefano Babic
Browse files

mx6: mx6qsabrelite/nitrogen6x: Remove incorrect setting of gpio CS signal


The number of gpio signal is packed inside CONFIG_SF_DEFAULT_CS macro
(shifted and or'ed with chip select), so it's incorrect to pass
that macro directly as an argument to gpio_direction_output() call.

Also, SPI driver sets the direction and initial value of a gpio,
used as a chip select signal, before any actual activity happens
on the bus.

So, it is safe to just remove the gpio_direction_output call,
that works incorrectly, thus making no effect, anyway.

Signed-off-by: default avatarAndrew Gabbasov <andrew_gabbasov@mentor.com>
Tested-by: default avatarRobert Winkler <robert.winkler@boundarydevices.com>
Acked-by: default avatarDirk Behme <dirk.behme@de.bosch.com>
parent a1f67807
No related branches found
No related tags found
No related merge requests found
...@@ -336,7 +336,6 @@ iomux_v3_cfg_t const ecspi1_pads[] = { ...@@ -336,7 +336,6 @@ iomux_v3_cfg_t const ecspi1_pads[] = {
void setup_spi(void) void setup_spi(void)
{ {
gpio_direction_output(CONFIG_SF_DEFAULT_CS, 1);
imx_iomux_v3_setup_multiple_pads(ecspi1_pads, imx_iomux_v3_setup_multiple_pads(ecspi1_pads,
ARRAY_SIZE(ecspi1_pads)); ARRAY_SIZE(ecspi1_pads));
} }
......
...@@ -308,7 +308,6 @@ iomux_v3_cfg_t const ecspi1_pads[] = { ...@@ -308,7 +308,6 @@ iomux_v3_cfg_t const ecspi1_pads[] = {
void setup_spi(void) void setup_spi(void)
{ {
gpio_direction_output(CONFIG_SF_DEFAULT_CS, 1);
imx_iomux_v3_setup_multiple_pads(ecspi1_pads, imx_iomux_v3_setup_multiple_pads(ecspi1_pads,
ARRAY_SIZE(ecspi1_pads)); ARRAY_SIZE(ecspi1_pads));
} }
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment