Skip to content
Snippets Groups Projects
Forked from Reform / reform-boundary-uboot
Source project has a limited visibility.
  • Gabe Black's avatar
    e81058c0
    ahci: Make sending the SETFEATURES_XFER command optional · e81058c0
    Gabe Black authored
    
    This command doesn't really do anything when talking to a SATA device, and
    sending it confuses some of them. This change makes sending the command
    optional, and defaults to not. The situations where it should be sent are not
    the common case.
    
    With the standard SSD in the machine, here are some times with the option
    turned off:
    1. 8277
    2. 8273
    3. 8050
    
    And turned on:
    1. 8303
    2. 8155
    3. 8276
    
    Sending that command seems to have no meaningful effect on performance.
    
    This fixes problems with an SSD marked Toshiba NV6424, Taiwan 11159AE P
    and TC58NVG5D2FTA10.
    
    Signed-off-by: default avatarGabe Black <gabeblack@chromium.org>
    Signed-off-by: default avatarTaylor Hutt <thutt@chromium.org>
    Signed-off-by: default avatarSimon Glass <sjg@chromium.org>
    e81058c0
    History
    ahci: Make sending the SETFEATURES_XFER command optional
    Gabe Black authored
    
    This command doesn't really do anything when talking to a SATA device, and
    sending it confuses some of them. This change makes sending the command
    optional, and defaults to not. The situations where it should be sent are not
    the common case.
    
    With the standard SSD in the machine, here are some times with the option
    turned off:
    1. 8277
    2. 8273
    3. 8050
    
    And turned on:
    1. 8303
    2. 8155
    3. 8276
    
    Sending that command seems to have no meaningful effect on performance.
    
    This fixes problems with an SSD marked Toshiba NV6424, Taiwan 11159AE P
    and TC58NVG5D2FTA10.
    
    Signed-off-by: default avatarGabe Black <gabeblack@chromium.org>
    Signed-off-by: default avatarTaylor Hutt <thutt@chromium.org>
    Signed-off-by: default avatarSimon Glass <sjg@chromium.org>