Skip to content
Snippets Groups Projects
Select Git revision
  • master default protected
  • early-display
  • variant-emmc-nvme-boot
  • 2023-01-25
  • v3
  • variant-emmc-nvme-boot
  • 2020-06-01
7 results

builderthread.py

Blame
  • Forked from Reform / reform-boundary-uboot
    Source project has a limited visibility.
    • Simon Glass's avatar
      88c8dcf9
      buildman: Adjust the 'aborted' heuristic for writing output · 88c8dcf9
      Simon Glass authored
      
      At present buildman tries to detect an aborted build and doesn't record a
      result in that case. This is to make sure that an abort (e.g. with Ctrl-C)
      does not mark the build as done. Without this option, buildman would never
      retry the build unless -f/-F are provided. The effect is that aborting the
      build creates 'fake errors' on whatever builds buildman happens to be
      working on at the time.
      
      Unfortunately the current test is not reliable and this detection can
      trigger if a required toolchain tool is missing. In this case the toolchain
      problem is never reported.
      
      Adjust the logic to continue processing the build result, mark the build as
      done (and failed), but with a return code which indicates that it should be
      retried.
      
      The correct fix is to fully and correctly detect an aborted build, quit
      buildman immediately and not write any partial build results in this case.
      Unfortunately this is currently beyond my powers and is left as an exercise
      for the reader (and patches are welcome).
      
      Signed-off-by: default avatarSimon Glass <sjg@chromium.org>
      88c8dcf9
      History
      buildman: Adjust the 'aborted' heuristic for writing output
      Simon Glass authored
      
      At present buildman tries to detect an aborted build and doesn't record a
      result in that case. This is to make sure that an abort (e.g. with Ctrl-C)
      does not mark the build as done. Without this option, buildman would never
      retry the build unless -f/-F are provided. The effect is that aborting the
      build creates 'fake errors' on whatever builds buildman happens to be
      working on at the time.
      
      Unfortunately the current test is not reliable and this detection can
      trigger if a required toolchain tool is missing. In this case the toolchain
      problem is never reported.
      
      Adjust the logic to continue processing the build result, mark the build as
      done (and failed), but with a return code which indicates that it should be
      retried.
      
      The correct fix is to fully and correctly detect an aborted build, quit
      buildman immediately and not write any partial build results in this case.
      Unfortunately this is currently beyond my powers and is left as an exercise
      for the reader (and patches are welcome).
      
      Signed-off-by: default avatarSimon Glass <sjg@chromium.org>