Skip to content
Snippets Groups Projects
Select Git revision
  • master default protected
  • early-display
  • variant-emmc-nvme-boot
  • 2023-01-25
  • v3
  • variant-emmc-nvme-boot
  • 2020-06-01
7 results

cmd_usb.c

Blame
  • Forked from Reform / reform-boundary-uboot
    Source project has a limited visibility.
    • Tom Rini's avatar
      b2fb47f1
      USB: Use (get|put)_unaligned for accessing wMaxPacketSize · b2fb47f1
      Tom Rini authored
      
      In 97929877 Stefan describes a usecase
      where the previous behavior of leaving wMaxPacketSize be unaligned
      caused fatal problems.  The initial fix for this problem was incomplete
      however as it showed another cases of non-aligned access that previously
      worked implicitly.  This switches to making sure that all access of
      wMaxPacketSize are done via (get|put)_unaligned.
      
      In order to maintain a level of readability to the code in some cases
      we now use a variable for the value of wMaxPacketSize and in others, a
      macro.
      
      Cc: Minkyu Kang <mk7.kang@samsung.com>
      Cc: Remy Bohmer <linux@bohmer.net>
      
      OpenRISC:
      Tested-by: default avatarStefan Kristiansson <stefan.kristiansson@saunalahti.fi>
      
      Beagleboard xM, Pandaboard run-tested, s5p_goni build-tested.
      Signed-off-by: default avatarTom Rini <trini@ti.com>
      b2fb47f1
      History
      USB: Use (get|put)_unaligned for accessing wMaxPacketSize
      Tom Rini authored
      
      In 97929877 Stefan describes a usecase
      where the previous behavior of leaving wMaxPacketSize be unaligned
      caused fatal problems.  The initial fix for this problem was incomplete
      however as it showed another cases of non-aligned access that previously
      worked implicitly.  This switches to making sure that all access of
      wMaxPacketSize are done via (get|put)_unaligned.
      
      In order to maintain a level of readability to the code in some cases
      we now use a variable for the value of wMaxPacketSize and in others, a
      macro.
      
      Cc: Minkyu Kang <mk7.kang@samsung.com>
      Cc: Remy Bohmer <linux@bohmer.net>
      
      OpenRISC:
      Tested-by: default avatarStefan Kristiansson <stefan.kristiansson@saunalahti.fi>
      
      Beagleboard xM, Pandaboard run-tested, s5p_goni build-tested.
      Signed-off-by: default avatarTom Rini <trini@ti.com>