Skip to content
Snippets Groups Projects
Forked from Reform / reform-boundary-uboot
Source project has a limited visibility.
  • Ilya Ledvich's avatar
    58c86c7d
    am33xx: fix the ddr_cmdtctrl structure · 58c86c7d
    Ilya Ledvich authored
    
    Fix the wrong mapping between the DDR I/O control registers on AM33XX
    SoCs and the software representation in the SPL code.
    The most recent public TRM defines the following DDR I/O control registers
    offsets:
     * ddr_cmd0_ioctrl : offset 0x44E11404
     * ddr_cmd1_ioctrl : offset 0x44E11408
     * ddr_cmd2_ioctrl : offset 0x44E1140C
     * ddr_data0_ioctrl: offset 0x44E11440
     * ddr_data1_ioctrl: offset 0x44E11444
    
    While the struct ddr_cmdtctrl has also some reserved bits in the beginning.
    The struct is mapped to the address 0x44E11404. As a result "cm0ioctl" points
    to the ddr_cmd1_ioctrl register, "cm1ioctl" to the ddr_cmd2_ioctrl and etc.
    Registers ddr_cmd0_ioctrl and ddr_data0_ioctrl are never configured because
    of this mapping mismatch.
    
    Signed-off-by: default avatarIlya Ledvich <ilya@compulab.co.il>
    Reviewed-by: default avatarPeter Korsgaard <jacmet@sunsite.dk>
    58c86c7d
    History
    am33xx: fix the ddr_cmdtctrl structure
    Ilya Ledvich authored
    
    Fix the wrong mapping between the DDR I/O control registers on AM33XX
    SoCs and the software representation in the SPL code.
    The most recent public TRM defines the following DDR I/O control registers
    offsets:
     * ddr_cmd0_ioctrl : offset 0x44E11404
     * ddr_cmd1_ioctrl : offset 0x44E11408
     * ddr_cmd2_ioctrl : offset 0x44E1140C
     * ddr_data0_ioctrl: offset 0x44E11440
     * ddr_data1_ioctrl: offset 0x44E11444
    
    While the struct ddr_cmdtctrl has also some reserved bits in the beginning.
    The struct is mapped to the address 0x44E11404. As a result "cm0ioctl" points
    to the ddr_cmd1_ioctrl register, "cm1ioctl" to the ddr_cmd2_ioctrl and etc.
    Registers ddr_cmd0_ioctrl and ddr_data0_ioctrl are never configured because
    of this mapping mismatch.
    
    Signed-off-by: default avatarIlya Ledvich <ilya@compulab.co.il>
    Reviewed-by: default avatarPeter Korsgaard <jacmet@sunsite.dk>