Skip to content
Snippets Groups Projects
Forked from Reform / reform-boundary-uboot
Source project has a limited visibility.
  • Stephen Warren's avatar
    3ee9593f
    dfu: add write error handling · 3ee9593f
    Stephen Warren authored
    
    Fix calls to dfu_write() and dfu_flush() to detect errors in the I/O
    itself. This could happen due to problems with the storage medium, or
    simply when trying to write a FAT/ext file that is larger than the buffer
    dfu_mmc.c maintains for this purpose.
    
    Signal the error by switching the DFU state/status. This will be picked
    up by the DFU client when it sends the next DFU request. Note that errors
    can't simply be returned from e.g. dnload_request_complete(), since that
    function has no way to pass errors back to the DFU client; a call to
    dnload_request_complete() simply means that a USB OUT completed.
    
    This error state/status needs to be cleared when the next DFU client
    connects. While there is a DFU_CLRSTATUS request, no DFU client seems to
    send this. Hence, clear this when selecting the USB alternate setting on
    the USB interface.
    
    Finally, dfu.c relies on a call to dfu_flush() to clear up the internal
    state of the write transaction. Now that errors in dfu_write() are
    detected, dfu_flush() may no longer be called for every transaction.
    Separate out the cleanup code into a new function, and call it whenever
    dfu_write() fails, as well as from any call to dfu_flush().
    
    Signed-off-by: default avatarStephen Warren <swarren@nvidia.com>
    3ee9593f
    History
    dfu: add write error handling
    Stephen Warren authored
    
    Fix calls to dfu_write() and dfu_flush() to detect errors in the I/O
    itself. This could happen due to problems with the storage medium, or
    simply when trying to write a FAT/ext file that is larger than the buffer
    dfu_mmc.c maintains for this purpose.
    
    Signal the error by switching the DFU state/status. This will be picked
    up by the DFU client when it sends the next DFU request. Note that errors
    can't simply be returned from e.g. dnload_request_complete(), since that
    function has no way to pass errors back to the DFU client; a call to
    dnload_request_complete() simply means that a USB OUT completed.
    
    This error state/status needs to be cleared when the next DFU client
    connects. While there is a DFU_CLRSTATUS request, no DFU client seems to
    send this. Hence, clear this when selecting the USB alternate setting on
    the USB interface.
    
    Finally, dfu.c relies on a call to dfu_flush() to clear up the internal
    state of the write transaction. Now that errors in dfu_write() are
    detected, dfu_flush() may no longer be called for every transaction.
    Separate out the cleanup code into a new function, and call it whenever
    dfu_write() fails, as well as from any call to dfu_flush().
    
    Signed-off-by: default avatarStephen Warren <swarren@nvidia.com>