Skip to content
Snippets Groups Projects
Forked from Reform / reform-boundary-uboot
Source project has a limited visibility.
  • Tom Rini's avatar
    bf52fcde
    cmd/gpt.c, cmd/nvedit.c, tools/fit_image.c: Rework recent fixes for Coverity · bf52fcde
    Tom Rini authored
    
    The recent changes to these files did not completely fix the previous
    issues, or introduced different (minor) issues.  In cmd/gpt.c we need to
    dereference str_disk_guid to be sure that malloc worked.  In
    cmd/nvedit.c we need to be careful that we can also fit in that leading
    space when adding to the string.  And in tools/fit_image.c we need to
    re-work the error handling slightly in fit_import_data() so that we only
    call munmap() once.  We have two error paths here, one where we have an
    fd to close and one where we do not.  Adjust labels to match this.
    
    Reported-by: Coverity (CID: 167366, 167367, 167370)
    Signed-off-by: default avatarTom Rini <trini@konsulko.com>
    bf52fcde
    History
    cmd/gpt.c, cmd/nvedit.c, tools/fit_image.c: Rework recent fixes for Coverity
    Tom Rini authored
    
    The recent changes to these files did not completely fix the previous
    issues, or introduced different (minor) issues.  In cmd/gpt.c we need to
    dereference str_disk_guid to be sure that malloc worked.  In
    cmd/nvedit.c we need to be careful that we can also fit in that leading
    space when adding to the string.  And in tools/fit_image.c we need to
    re-work the error handling slightly in fit_import_data() so that we only
    call munmap() once.  We have two error paths here, one where we have an
    fd to close and one where we do not.  Adjust labels to match this.
    
    Reported-by: Coverity (CID: 167366, 167367, 167370)
    Signed-off-by: default avatarTom Rini <trini@konsulko.com>