From 3b593f9030bae149af9261f51933805be506f6b1 Mon Sep 17 00:00:00 2001 From: "tomas.melin@vaisala.com" <tomas.melin@vaisala.com> Date: Wed, 16 Nov 2016 13:02:32 +0200 Subject: [PATCH] splash: fix splash source flags check SPLASH_STORAGE_RAW is defined as 0, so a check against & will never be true. These flags are never combined so do a check against == instead. Signed-off-by: Tomas Melin <tomas.melin@vaisala.com> Reviewed-by: Tom Rini <trini@konsulko.com> --- common/splash_source.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/common/splash_source.c b/common/splash_source.c index 4c64f10c500..a5eeb3f12c5 100644 --- a/common/splash_source.c +++ b/common/splash_source.c @@ -395,9 +395,9 @@ int splash_source_load(struct splash_location *locations, uint size) if (!splash_location) return -EINVAL; - if (splash_location->flags & SPLASH_STORAGE_RAW) + if (splash_location->flags == SPLASH_STORAGE_RAW) return splash_load_raw(splash_location, bmp_load_addr); - else if (splash_location->flags & SPLASH_STORAGE_FS) + else if (splash_location->flags == SPLASH_STORAGE_FS) return splash_load_fs(splash_location, bmp_load_addr); #ifdef CONFIG_FIT else if (splash_location->flags == SPLASH_STORAGE_FIT) -- GitLab